From 4440fa665932fa381a9f7191cd06bc6063af1517 Mon Sep 17 00:00:00 2001 From: th-kim0823 Date: Sun, 10 May 2026 18:08:29 +0900 Subject: [PATCH] fix(fb-38): add score_kind to remaining SearchHit literals Add missing score_kind field to SearchHit constructors in: - kebab-tui/tests/search.rs::make_hit() - kebab-eval/tests/metrics_and_compare.rs::hit() - kebab-eval/src/metrics.rs::hit() All test fixtures default to Rrf (hybrid mode), matching the field's Default impl and the test semantics. Co-Authored-By: Claude Opus 4.7 (1M context) --- crates/kebab-eval/src/metrics.rs | 1 + crates/kebab-eval/tests/metrics_and_compare.rs | 1 + crates/kebab-tui/tests/search.rs | 1 + 3 files changed, 3 insertions(+) diff --git a/crates/kebab-eval/src/metrics.rs b/crates/kebab-eval/src/metrics.rs index 1528e23..dd1bf7d 100644 --- a/crates/kebab-eval/src/metrics.rs +++ b/crates/kebab-eval/src/metrics.rs @@ -448,6 +448,7 @@ mod tests { // pin UNIX_EPOCH + stale=false so hits stay deterministic. indexed_at: OffsetDateTime::UNIX_EPOCH, stale: false, + score_kind: kebab_core::ScoreKind::Rrf, } } diff --git a/crates/kebab-eval/tests/metrics_and_compare.rs b/crates/kebab-eval/tests/metrics_and_compare.rs index 06cb78c..1e1b366 100644 --- a/crates/kebab-eval/tests/metrics_and_compare.rs +++ b/crates/kebab-eval/tests/metrics_and_compare.rs @@ -86,6 +86,7 @@ fn hit(rank: u32, chunk_id: &str, doc_id: &str) -> SearchHit { // pin UNIX_EPOCH + stale=false so hits stay deterministic. indexed_at: OffsetDateTime::UNIX_EPOCH, stale: false, + score_kind: kebab_core::ScoreKind::Rrf, } } diff --git a/crates/kebab-tui/tests/search.rs b/crates/kebab-tui/tests/search.rs index 468ac2c..b3dd31b 100644 --- a/crates/kebab-tui/tests/search.rs +++ b/crates/kebab-tui/tests/search.rs @@ -55,6 +55,7 @@ fn make_hit(rank: u32, path: &str, snippet: &str, citation: Citation) -> SearchH // staleness rendering covered in dedicated tests (Task 11). indexed_at: time::OffsetDateTime::UNIX_EPOCH, stale: false, + score_kind: kebab_core::ScoreKind::Rrf, } }