chore: workspace-wide cleanup — clippy::pedantic baseline + auto-fix
cut PR v0.18.0 전 마지막 정리. 사용자 요청: "전체 코드베이스를 깔끔하고 알아보기 쉽게".
## Workspace lints
- `Cargo.toml` 의 `[workspace.lints.clippy]` 에 `pedantic = "warn"` (priority -1) + 의도적 allow-list 추가:
- cast_possible_truncation / cast_possible_wrap / cast_sign_loss / cast_precision_loss — ONNX i64 / hash modular reduction 등 의도적 truncation.
- doc_markdown / missing_errors_doc / missing_panics_doc — cosmetic doc style.
- too_many_lines / module_name_repetitions / must_use_candidate / needless_pass_by_value / manual_let_else / items_after_statements / similar_names — informational only.
- format_collect / match_wildcard_for_single_variants / trivially_copy_pass_by_ref / unnecessary_wraps — intentional patterns (exhaustive match, future Result variants 등).
- default_trait_access — `Foo::default()` 가 idiomatic.
- float_cmp — NLI / RRF score 의 explicit threshold 비교 의도.
- struct_excessive_bools / case_sensitive_file_extension_comparisons / naive_bytecount / ignore_without_reason — domain-specific 의도.
- format_push_string / return_self_not_must_use / match_same_arms — builder / wire-label / hot-path 패턴 보존.
- needless_continue / used_underscore_binding / nonminimal_bool / unreadable_literal / many_single_char_names / doc_link_with_quotes / assigning_clones / collapsible_str_replace / trivial_regex / elidable_lifetime_names / range_plus_one / explicit_iter_loop / implicit_hasher / ref_option — remaining low-value style.
- 각 24 crate `Cargo.toml` 에 `[lints] workspace = true` 추가.
## Auto-fix
`cargo clippy --workspace --all-targets --fix` 적용 — 128 files changed, 552 insertions / 472 deletions. 주로:
- uninlined_format_args (~18): `format!("{}", x)` → `format!("{x}")`.
- redundant_closure_for_method_calls (~33): `.map(|x| x.foo())` → `.map(T::foo)`.
- 그 외 mechanical refactor.
## 검증
- `cargo clippy --workspace --all-targets -j 1 -- -D warnings` clean (pedantic + 모든 lint group).
- `cargo test --workspace --no-fail-fast -j 1` — **1293 tests pass + 1 pre-existing flaky fail** (`kebab-mcp::tools_call_ask_multi_hop::ask_tool_routes_multi_hop_true_to_decompose_first`, HOTFIX candidate, cleanup 무관). 회귀 0.
Wire 영향: 없음.
Behavior 영향: 없음 (mechanical refactor only).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -86,7 +86,7 @@ fn fts_v002_backfills_existing_chunks() {
|
||||
// on a customer DB upgrading from P1 to P2-1).
|
||||
const N: usize = 4;
|
||||
for i in 0..N {
|
||||
let cid = format!("{:0>32}", i);
|
||||
let cid = format!("{i:0>32}");
|
||||
insert_chunk(
|
||||
&conn,
|
||||
&cid,
|
||||
@@ -112,7 +112,7 @@ fn fts_v002_backfills_existing_chunks() {
|
||||
"V002 backfill INSERT must seed one chunks_fts row per chunks row"
|
||||
);
|
||||
for i in 0..N {
|
||||
let cid = format!("{:0>32}", i);
|
||||
let cid = format!("{i:0>32}");
|
||||
let term = format!("seedrow{i}");
|
||||
let hit: String = conn
|
||||
.query_row(
|
||||
@@ -137,7 +137,7 @@ fn fts_v002_backfill_select_matches_chunks_count() {
|
||||
|
||||
let conn = raw_conn_no_fk(&env);
|
||||
for i in 0..5 {
|
||||
let cid = format!("{:0>32}", i);
|
||||
let cid = format!("{i:0>32}");
|
||||
insert_chunk(&conn, &cid, &"d".repeat(32), "[]", &format!("row {i}"));
|
||||
}
|
||||
// Wipe + run the literal V002 backfill INSERT.
|
||||
@@ -250,7 +250,7 @@ fn fts_rebuild_chunks_fts_is_idempotent() {
|
||||
|
||||
let conn = raw_conn_no_fk(&env);
|
||||
for i in 0..3 {
|
||||
let cid = format!("{:0>32}", i);
|
||||
let cid = format!("{i:0>32}");
|
||||
insert_chunk(&conn, &cid, &"d".repeat(32), "[]", &format!("token{i}"));
|
||||
}
|
||||
let before = count(&conn, "chunks_fts");
|
||||
@@ -396,8 +396,7 @@ fn extract_migration_5_5_verbatim_block() -> String {
|
||||
// Walk back from the close marker to the start of its comment line.
|
||||
let close_line_start = migration[..close_idx]
|
||||
.rfind('\n')
|
||||
.map(|n| n + 1)
|
||||
.unwrap_or(0);
|
||||
.map_or(0, |n| n + 1);
|
||||
|
||||
migration[after_open_line..close_line_start].to_string()
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user