review(회차1): 회차 1 지적 5건 반영
- p9-dogfooding-feedback.md item 14: README 오타 (READE → README) - p9-fb-11.md frontmatter: depends_on=[p9-fb-14] 추가 (14.unblocks 와 양방향 정합) - p9-fb-01.md Behavior contract: '14 번과 wiring' 모호 cross-ref 정정 — cancel wiring 은 p9-fb-04, TUI 신호는 p9-fb-03 - plan File Structure: 'tasks/HOTFIXES.md — n/a (skip)' 자기모순 제거 → 별도 HOTFIXES 절로 분리 - plan task 4 handler: let _ = data_only; 제거, pattern binding 자체를 data_only: _ 로 변경 (관용적) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -24,10 +24,11 @@
|
||||
- `crates/kebab-cli/src/main.rs` — add `Cmd::Reset` arm + handler
|
||||
- `crates/kebab-cli/src/wire.rs` — `wire_reset` helper
|
||||
- `README.md` — `kebab reset` in 명령 표 + Quick start safety note
|
||||
- `tasks/HOTFIXES.md` — n/a (new feature, not deviation; skip)
|
||||
|
||||
**Delete:** none.
|
||||
|
||||
**HOTFIXES:** n/a — 신규 기능이지 deviation 아님. `tasks/HOTFIXES.md` 는 건드리지 않음.
|
||||
|
||||
---
|
||||
|
||||
## Task 1: `kebab-store-sqlite::truncate_embedding_records`
|
||||
@@ -728,12 +729,16 @@ In `fn run(cli: &Cli) -> anyhow::Result<()>`, just above the `Cmd::Doctor =>` ar
|
||||
```rust
|
||||
Cmd::Reset {
|
||||
all,
|
||||
data_only,
|
||||
data_only: _,
|
||||
vector_only,
|
||||
config_only,
|
||||
yes,
|
||||
} => {
|
||||
use kebab_app::ResetScope;
|
||||
// `--data-only` explicit OR no scope flag at all → DataOnly.
|
||||
// The `data_only: _` binding above is intentional — clap's
|
||||
// `group = "reset_scope"` already enforces mutual exclusion,
|
||||
// so the flag's presence does not change the resolved scope.
|
||||
let scope = if *all {
|
||||
ResetScope::All
|
||||
} else if *vector_only {
|
||||
@@ -741,8 +746,6 @@ In `fn run(cli: &Cli) -> anyhow::Result<()>`, just above the `Cmd::Doctor =>` ar
|
||||
} else if *config_only {
|
||||
ResetScope::ConfigOnly
|
||||
} else {
|
||||
// `--data-only` explicit OR no scope flag at all → DataOnly
|
||||
let _ = data_only;
|
||||
ResetScope::DataOnly
|
||||
};
|
||||
|
||||
|
||||
Reference in New Issue
Block a user