From b19ebfd2bccdc4044d7bf4645b4856369063f2d5 Mon Sep 17 00:00:00 2001 From: altair823 Date: Sat, 2 May 2026 23:14:12 +0000 Subject: [PATCH] =?UTF-8?q?review(=ED=9A=8C=EC=B0=A81):=20AskOpts::single?= =?UTF-8?q?=5Fshot=20helper=20=EC=A0=9C=EA=B1=B0=20(yagni)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 회차 1 nit 반영. helper 가 본 PR 안 caller 0 — 모든 사용처가 struct literal 패턴. CLAUDE.md "Don't add abstractions beyond what the task requires" 룰. 미래 caller 가 필요 시 본인이 추가. Co-Authored-By: Claude Opus 4.7 (1M context) --- crates/kebab-rag/src/pipeline.rs | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/crates/kebab-rag/src/pipeline.rs b/crates/kebab-rag/src/pipeline.rs index 62dd40c..8c39c44 100644 --- a/crates/kebab-rag/src/pipeline.rs +++ b/crates/kebab-rag/src/pipeline.rs @@ -98,25 +98,6 @@ pub struct AskOpts { pub turn_index: Option, } -impl AskOpts { - /// Default knobs for a single-shot ask (no history, no - /// conversation_id). `k` falls through to the config floor in - /// `RagPipeline::ask`. - pub fn single_shot(mode: SearchMode) -> Self { - Self { - k: 0, - explain: false, - mode, - temperature: None, - seed: None, - stream_sink: None, - history: Vec::new(), - conversation_id: None, - turn_index: None, - } - } -} - // ── RagPipeline ───────────────────────────────────────────────────────────── /// Single-threaded RAG orchestrator. See module docs for the stage list.