review(p9-fb-25-task1): fix kebab-app test references to removed WorkspaceCfg.include

reviewer-flagged: task 1 missed test files using cfg.workspace.include.

- crates/kebab-app/tests/common/mod.rs: SourceScope literal switched
  to ..Default::default().
- crates/kebab-app/tests/image_pipeline.rs (×3): drop dead-no-op
  cfg.workspace.include.push(...) calls; comment explains removal.
- crates/kebab-app/tests/pdf_pipeline.rs: same treatment.

Pre-fb-25 these pushes were no-ops (include was dead config field
not enforced anywhere). Removal is purely mechanical.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-05-05 11:53:19 +00:00
parent 7f31721a47
commit ef5d0770ae
3 changed files with 9 additions and 8 deletions

View File

@@ -75,8 +75,8 @@ impl TestEnv {
pub fn scope(&self) -> kebab_core::SourceScope { pub fn scope(&self) -> kebab_core::SourceScope {
kebab_core::SourceScope { kebab_core::SourceScope {
root: self.workspace_root.clone(), root: self.workspace_root.clone(),
include: self.config.workspace.include.clone(),
exclude: self.config.workspace.exclude.clone(), exclude: self.config.workspace.exclude.clone(),
..Default::default()
} }
} }
} }

View File

@@ -33,10 +33,8 @@ fn write_red_png(root: &Path, name: &str) -> std::path::PathBuf {
fn cfg_with_image_pipeline(env: &TestEnv, mock_endpoint: &str) -> Config { fn cfg_with_image_pipeline(env: &TestEnv, mock_endpoint: &str) -> Config {
let mut cfg = env.config.clone(); let mut cfg = env.config.clone();
// Ensure image assets are scanned. // p9-fb-25: workspace.include removed; extension routing is now
cfg.workspace // handled by extractor matching alone (no config knob).
.include
.push("**/*.png".to_string());
cfg.image.ocr.enabled = true; cfg.image.ocr.enabled = true;
cfg.image.ocr.endpoint = Some(mock_endpoint.to_string()); cfg.image.ocr.endpoint = Some(mock_endpoint.to_string());
cfg.image.ocr.model = "vision-mock:1b".to_string(); cfg.image.ocr.model = "vision-mock:1b".to_string();
@@ -261,7 +259,8 @@ async fn image_indexed_with_filename_when_ocr_and_caption_disabled() {
let env = TestEnv::lexical_only(); let env = TestEnv::lexical_only();
write_red_png(&env.workspace_root, "raw.png"); write_red_png(&env.workspace_root, "raw.png");
let mut cfg = env.config.clone(); let mut cfg = env.config.clone();
cfg.workspace.include.push("**/*.png".to_string()); // p9-fb-25: workspace.include removed; extension routing is now
// handled by extractor matching alone (no config knob).
cfg.image.ocr.enabled = false; cfg.image.ocr.enabled = false;
cfg.image.caption.enabled = false; cfg.image.caption.enabled = false;
@@ -326,7 +325,8 @@ async fn garbage_png_increments_errors_counter_exactly_once() {
) )
.expect("write garbage fixture"); .expect("write garbage fixture");
let mut cfg = env.config.clone(); let mut cfg = env.config.clone();
cfg.workspace.include.push("**/*.png".to_string()); // p9-fb-25: workspace.include removed; extension routing is now
// handled by extractor matching alone (no config knob).
cfg.image.ocr.enabled = false; cfg.image.ocr.enabled = false;
cfg.image.caption.enabled = false; cfg.image.caption.enabled = false;

View File

@@ -121,7 +121,8 @@ fn write_pdf(root: &Path, name: &str, bytes: &[u8]) -> std::path::PathBuf {
fn cfg_with_pdf(env: &TestEnv) -> Config { fn cfg_with_pdf(env: &TestEnv) -> Config {
let mut cfg = env.config.clone(); let mut cfg = env.config.clone();
cfg.workspace.include.push("**/*.pdf".to_string()); // p9-fb-25: workspace.include removed; extension routing is now
// handled by extractor matching alone (no config knob).
// PDF ingest does not need OCR / caption / LM — leave defaults // PDF ingest does not need OCR / caption / LM — leave defaults
// (ocr.enabled=false, caption.enabled=false). The image pipeline // (ocr.enabled=false, caption.enabled=false). The image pipeline
// construction step skips both adapters. // construction step skips both adapters.