th-kim0823
|
7dddc1d706
|
fix(fb-35): address PR #126 round 1 review
- fetch_span: panic-fix on line_start > total / empty doc
(return empty text + effective_end = line_start - 1 instead of
out-of-bounds slice)
- truncated: reserved for budget-driven truncation only; line
range clamp signaled via effective_end < line_end
- spec / SKILL.md / README: align rejection wording to "PDF /
audio" (matches code; Image OCR allowed for span)
- store: warning comment on list_chunk_ids_for_doc — chunk_id
hash sort does NOT preserve document position; real fix is a
chunks.ordinal column, tracked as follow-up
- surrounding_chunks: saturating_add to defend against u32::MAX
context arg on 32-bit targets
- tests: line_start > total returns empty + chunk context at
doc boundary clamps lower bound
Deferred nits (follow-up): table-separator strict CommonMark form;
MCP per-mode strict validation; CLI chunk_id truncation in plain
output. None block correctness.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
2026-05-10 00:45:29 +09:00 |
|