kebab

altair823-org/kebab

Fork 0

Commit Graph

Author	SHA1	Message	Date
altair823	5af07c174d	p0-1: address quality review (wire convention, IngestItemKind re-export, clippy) Three follow-ups from the code-quality review pass on P0-1: - Re-export `IngestItemKind` from `kb-core` so downstream tasks constructing `IngestItem` don't need `kb_core::ingest::IngestItemKind`. - Document the `--json` wire-schema convention by introducing `kb-cli/src/wire.rs` with `wire_*` helpers paralleling the existing inline `wire_ingest`. Each Ok-path `--json` branch now routes through these helpers so future P1-5/P3/P4/P5 implementations slot the `schema_version` envelope in automatically. `DoctorReport` keeps its struct-field `schema_version` (the documented exception), and the helper round-trips it idempotently. Records the convention in `kb-app/src/lib.rs`'s top docstring. - Fix clippy `single_char_add_str` in `kb_core::normalize` (replace `out.push_str(".")` with `out.push('.')`). Verified: `cargo check`, `cargo test` (5 new wire-helper tests), `cargo clippy -D warnings`, and `RUSTFLAGS=-D warnings cargo build` all clean. Smoke-tested `kb doctor --json` still emits `{"schema_version":"doctor.v1",...}`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-04-30 05:33:31 +00:00
altair823	ec8a4ddb1b	p0-1: kb-cli clap entry with §10 exit-code mapping Adds the kb binary with clap v4 derive subcommands mapping 1:1 to kb-app facade functions: init \| ingest \| list docs \| inspect (doc\|chunk) \| search \| ask \| doctor \| eval run Global flags: --config, --verbose, --debug, --json. On --json, output conforms to wire schema v1 (e.g. doctor.v1 emitted by kb-app::doctor). Exit-code mapping per design §10: 0 success 1 RefusalSignal / NoHitSignal (kb ask refusal, kb search no-hit) 2 any other anyhow::Error 3 DoctorUnhealthy Tracing initialized at startup with the file appender from kb-app. Verified via: XDG_=… cargo run -p kb-cli -- init → idempotent XDG_=… cargo run -p kb-cli -- doctor --json → {"schema_version":"doctor.v1","ok":true,…} exit 0 XDG_*=… cargo run -p kb-cli -- doctor (human form, ✓ marks) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-04-30 05:17:18 +00:00

Author

SHA1

Message

Date

altair823

5af07c174d

p0-1: address quality review (wire convention, IngestItemKind re-export, clippy)

Three follow-ups from the code-quality review pass on P0-1:

- Re-export `IngestItemKind` from `kb-core` so downstream tasks
  constructing `IngestItem` don't need `kb_core::ingest::IngestItemKind`.
- Document the `--json` wire-schema convention by introducing
  `kb-cli/src/wire.rs` with `wire_*` helpers paralleling the existing
  inline `wire_ingest`. Each Ok-path `--json` branch now routes through
  these helpers so future P1-5/P3/P4/P5 implementations slot the
  `schema_version` envelope in automatically. `DoctorReport` keeps its
  struct-field `schema_version` (the documented exception), and the
  helper round-trips it idempotently. Records the convention in
  `kb-app/src/lib.rs`'s top docstring.
- Fix clippy `single_char_add_str` in `kb_core::normalize` (replace
  `out.push_str(".")` with `out.push('.')`).

Verified: `cargo check`, `cargo test` (5 new wire-helper tests),
`cargo clippy -D warnings`, and `RUSTFLAGS=-D warnings cargo build` all
clean. Smoke-tested `kb doctor --json` still emits
`{"schema_version":"doctor.v1",...}`.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

2026-04-30 05:33:31 +00:00

altair823

ec8a4ddb1b

p0-1: kb-cli clap entry with §10 exit-code mapping

Adds the kb binary with clap v4 derive subcommands mapping 1:1 to
kb-app facade functions:

  init | ingest | list docs | inspect (doc|chunk) | search | ask
  | doctor | eval run

Global flags: --config, --verbose, --debug, --json. On --json, output
conforms to wire schema v1 (e.g. doctor.v1 emitted by kb-app::doctor).

Exit-code mapping per design §10:
  0 success
  1 RefusalSignal / NoHitSignal (kb ask refusal, kb search no-hit)
  2 any other anyhow::Error
  3 DoctorUnhealthy

Tracing initialized at startup with the file appender from kb-app.

Verified via:
  XDG_*=… cargo run -p kb-cli -- init    → idempotent
  XDG_*=… cargo run -p kb-cli -- doctor --json
    → {"schema_version":"doctor.v1","ok":true,…} exit 0
  XDG_*=… cargo run -p kb-cli -- doctor   (human form, ✓ marks)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

2026-04-30 05:17:18 +00:00

2 Commits