chore(p10-2-followup): reviewer nit cleanup — Mermaid + 주석 + oversize test #154

altair823 · 2026-05-20T14:41:48Z

altair823 commented

2026-05-20 14:41:48 +00:00

Summary

PR #153 (p10-2 Tier 2) code-reviewer 의 non-blocking nit 3개 묶음 cleanup. 동작 변경 없음, version bump 없음.

nit #1: tier2_shared::push_chunks_with_oversize 의 line-window split 분기에 명시적 테스트 fixture 추가 — 250 data key 의 ConfigMap 으로 256 라인 생성. 다음을 검증:
- ≥2 chunk emit (split 발생).
- 모든 chunk 의 symbol = ConfigMap/prod/big (동일 유지).
- chunk_id 모두 distinct (id_for_chunk 의 #L{k} suffix 동작 확인).
- line range 연속 partition (prev.line_end + 1 == next.line_start).
nit #2: README 의 Mermaid 다이어그램 chunker_version 열거 — 1C-JK 부터 누락이었던 code-java-ast-v1 / code-kotlin-ast-v1 + p10-2 의 k8s-manifest-resource-v1 / dockerfile-file-v1 / manifest-file-v1 추가. 표기 단순화로 code-*-ast-v1 는 brace 묶음.
nit #3: synthesize_tier2_document 의 path resolution 주석 정정. 이전 "mirrors RustAstExtractor pattern" 표현이 실제 동작 (FsSourceConnector 의 absolute-path 불변 의존) 과 다름. 명확히 rephrase + Kb URI fallback 의 defensive 성격 명시.

Test plan

cargo test -p kebab-chunk --test k8s_manifest_resource_v1 PASS (4 tests, 신규 oversize 포함)
cargo clippy -p kebab-chunk --tests -- -D warnings clean
cargo build -p kebab-app clean (nit #3 의 주석 변경)
post-merge: 별도 dogfood 또는 release 없음 (no behavior change)

Branch

chore/p10-2-followup-nits (head: 75c1c7b). 분리 commit 3개로 review 용이.

Reviewer 의 follow-up nit 들 (PR #153 참조).

🤖 Generated with Claude Code

## Summary PR #153 (p10-2 Tier 2) code-reviewer 의 non-blocking nit 3개 묶음 cleanup. 동작 변경 없음, version bump 없음. - **nit #1**: `tier2_shared::push_chunks_with_oversize` 의 line-window split 분기에 명시적 테스트 fixture 추가 — 250 data key 의 ConfigMap 으로 256 라인 생성. 다음을 검증: - ≥2 chunk emit (split 발생). - 모든 chunk 의 symbol = `ConfigMap/prod/big` (동일 유지). - chunk_id 모두 distinct (`id_for_chunk` 의 `#L{k}` suffix 동작 확인). - line range 연속 partition (prev.line_end + 1 == next.line_start). - **nit #2**: README 의 Mermaid 다이어그램 chunker_version 열거 — 1C-JK 부터 누락이었던 `code-java-ast-v1` / `code-kotlin-ast-v1` + p10-2 의 `k8s-manifest-resource-v1` / `dockerfile-file-v1` / `manifest-file-v1` 추가. 표기 단순화로 `code-*-ast-v1` 는 brace 묶음. - **nit #3**: `synthesize_tier2_document` 의 path resolution 주석 정정. 이전 "mirrors RustAstExtractor pattern" 표현이 실제 동작 (FsSourceConnector 의 absolute-path 불변 의존) 과 다름. 명확히 rephrase + Kb URI fallback 의 defensive 성격 명시. ## Test plan - [x] `cargo test -p kebab-chunk --test k8s_manifest_resource_v1` PASS (4 tests, 신규 oversize 포함) - [x] `cargo clippy -p kebab-chunk --tests -- -D warnings` clean - [x] `cargo build -p kebab-app` clean (nit #3 의 주석 변경) - [ ] post-merge: 별도 dogfood 또는 release 없음 (no behavior change) ## Branch `chore/p10-2-followup-nits` (head: `75c1c7b`). 분리 commit 3개로 review 용이. Reviewer 의 follow-up nit 들 ([PR #153](http://gitea.altair823.xyz/altair823-org/kebab/pulls/153) 참조). 🤖 Generated with [Claude Code](https://claude.com/claude-code)

altair823 added 3 commits 2026-05-20 14:41:48 +00:00

docs(p10-2-followup): README Mermaid chunker_version list — Java/Kotlin + Tier 2 a1192ce3b2

p10-1C-JK 이후 누락된 code-java-ast-v1 / code-kotlin-ast-v1 + p10-2 의
k8s-manifest-resource-v1 / dockerfile-file-v1 / manifest-file-v1 추가.
표기 단순화를 위해 code-* 는 brace 묶음.

Reviewer nit #2 (PR #153 code-reviewer).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

docs(p10-2-followup): clarify synthesize_tier2_document path resolution comment b5c12ecb6f

Earlier comment claimed the function "mirrors RustAstExtractor pattern" but
the two differ: RustAstExtractor joins ctx.workspace_root to handle relative
paths, while Tier 2 trusts FsSourceConnector's absolute-path invariant.
Rephrase to document the actual rationale + the Kb URI fallback.

Reviewer nit #3 (PR #153 code-reviewer).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

test(p10-2-followup): cover tier2_shared oversize fallback with >200-line k8s ConfigMap 75c1c7b911

Spec p10-2 risks section calls out "거대 ConfigMap" but no test exercised
the line-window split branch of tier2_shared::push_chunks_with_oversize.
This adds a 256-line ConfigMap fixture (generated inline) and asserts:
- ≥2 chunks emitted (split happened),
- all chunks share symbol `ConfigMap/prod/big`,
- chunk_ids all distinct (id_for_chunk's #L{k} suffix disambiguation),
- line ranges form a contiguous partition (prev.line_end + 1 == next.line_start).

Reviewer nit #1 (PR #153 code-reviewer).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

altair823 merged commit 8ce7a911ee into main

2026-05-20 14:44:41 +00:00

altair823 deleted branch chore/p10-2-followup-nits

2026-05-20 14:44:42 +00:00

altair823 referenced this issue from a commit

2026-05-20 14:44:43 +00:00

chore(p10-2-followup): reviewer nit cleanup — Mermaid + 주석 + oversize test (#154)

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: altair823-org/kebab#154