altair823
7c85de065a
cut PR v0.18.0 전 마지막 정리. 사용자 요청: "전체 코드베이스를 깔끔하고 알아보기 쉽게".
## Workspace lints
- `Cargo.toml` 의 `[workspace.lints.clippy]` 에 `pedantic = "warn"` (priority -1) + 의도적 allow-list 추가:
- cast_possible_truncation / cast_possible_wrap / cast_sign_loss / cast_precision_loss — ONNX i64 / hash modular reduction 등 의도적 truncation.
- doc_markdown / missing_errors_doc / missing_panics_doc — cosmetic doc style.
- too_many_lines / module_name_repetitions / must_use_candidate / needless_pass_by_value / manual_let_else / items_after_statements / similar_names — informational only.
- format_collect / match_wildcard_for_single_variants / trivially_copy_pass_by_ref / unnecessary_wraps — intentional patterns (exhaustive match, future Result variants 등).
- default_trait_access — `Foo::default()` 가 idiomatic.
- float_cmp — NLI / RRF score 의 explicit threshold 비교 의도.
- struct_excessive_bools / case_sensitive_file_extension_comparisons / naive_bytecount / ignore_without_reason — domain-specific 의도.
- format_push_string / return_self_not_must_use / match_same_arms — builder / wire-label / hot-path 패턴 보존.
- needless_continue / used_underscore_binding / nonminimal_bool / unreadable_literal / many_single_char_names / doc_link_with_quotes / assigning_clones / collapsible_str_replace / trivial_regex / elidable_lifetime_names / range_plus_one / explicit_iter_loop / implicit_hasher / ref_option — remaining low-value style.
- 각 24 crate `Cargo.toml` 에 `[lints] workspace = true` 추가.
## Auto-fix
`cargo clippy --workspace --all-targets --fix` 적용 — 128 files changed, 552 insertions / 472 deletions. 주로:
- uninlined_format_args (~18): `format!("{}", x)` → `format!("{x}")`.
- redundant_closure_for_method_calls (~33): `.map(|x| x.foo())` → `.map(T::foo)`.
- 그 외 mechanical refactor.
## 검증
- `cargo clippy --workspace --all-targets -j 1 -- -D warnings` clean (pedantic + 모든 lint group).
- `cargo test --workspace --no-fail-fast -j 1` — **1293 tests pass + 1 pre-existing flaky fail** (`kebab-mcp::tools_call_ask_multi_hop::ask_tool_routes_multi_hop_true_to_decompose_first`, HOTFIX candidate, cleanup 무관). 회귀 0.
Wire 영향: 없음.
Behavior 영향: 없음 (mechanical refactor only).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
87 lines
4.2 KiB
TOML
87 lines
4.2 KiB
TOML
[package]
|
|
name = "kebab-app"
|
|
version = { workspace = true }
|
|
edition = { workspace = true }
|
|
rust-version = { workspace = true }
|
|
license = { workspace = true }
|
|
repository = { workspace = true }
|
|
description = "Facade — orchestrates components for kb-cli/tui/desktop"
|
|
|
|
[dependencies]
|
|
kebab-core = { path = "../kebab-core" }
|
|
kebab-config = { path = "../kebab-config" }
|
|
kebab-source-fs = { path = "../kebab-source-fs" }
|
|
kebab-parse-md = { path = "../kebab-parse-md" }
|
|
kebab-parse-types = { path = "../kebab-parse-types" }
|
|
kebab-normalize = { path = "../kebab-normalize" }
|
|
kebab-chunk = { path = "../kebab-chunk" }
|
|
kebab-store-sqlite = { path = "../kebab-store-sqlite" }
|
|
kebab-store-vector = { path = "../kebab-store-vector" }
|
|
kebab-search = { path = "../kebab-search" }
|
|
kebab-embed = { path = "../kebab-embed" }
|
|
kebab-embed-local = { path = "../kebab-embed-local" }
|
|
kebab-llm = { path = "../kebab-llm" }
|
|
kebab-llm-local = { path = "../kebab-llm-local" }
|
|
kebab-rag = { path = "../kebab-rag" }
|
|
# p9-fb-41 PR-9c-2: facade construction of OnnxNliVerifier when
|
|
# `[rag] nli_threshold > 0`. Trait-only consumption via kebab-rag's
|
|
# `with_verifier`; no kebab-nli internals leak into kebab-app code
|
|
# beyond the construction site in `open_with_config`.
|
|
kebab-nli = { path = "../kebab-nli" }
|
|
# P6-4: image extractor + OCR + caption adapters live here. App
|
|
# threads them into the per-asset dispatch (see `ingest_one_asset`
|
|
# image branch). Trait-only consumption — no `kebab-parse-image`
|
|
# internals leak into kb-app code.
|
|
kebab-parse-image = { path = "../kebab-parse-image" }
|
|
# P7-3: PDF text extractor lives here. App threads it into the
|
|
# per-asset dispatch (see `ingest_one_asset` PDF branch) and runs the
|
|
# resulting `CanonicalDocument` through `kebab-chunk::PdfPageV1Chunker`.
|
|
kebab-parse-pdf = { path = "../kebab-parse-pdf" }
|
|
# p10-1A-2: Rust AST extractor lives here. App threads it into the
|
|
# per-asset dispatch (see `ingest_one_asset` Code branch) and runs the
|
|
# resulting `CanonicalDocument` through `kebab-chunk::CodeRustAstV1Chunker`.
|
|
kebab-parse-code = { path = "../kebab-parse-code" }
|
|
anyhow = { workspace = true }
|
|
blake3 = { workspace = true }
|
|
serde = { workspace = true }
|
|
serde_json = { workspace = true }
|
|
time = { workspace = true }
|
|
tracing = { workspace = true }
|
|
tracing-subscriber = { version = "0.3", features = ["env-filter", "fmt", "json"] }
|
|
tracing-appender = "0.2"
|
|
toml = "0.8"
|
|
dirs = "5"
|
|
# p9-fb-19: in-process LRU cache for `App::search`. Capacity from
|
|
# `config.search.cache_capacity` (default 256, ~1.3 MB cap).
|
|
lru = { workspace = true }
|
|
# p9-fb-19: NFKC-normalize cache-key queries so `"Foo"` / `"FOO"` /
|
|
# `" foo "` collapse to one entry. Same crate kebab-normalize +
|
|
# kebab-core already use, no version drift.
|
|
unicode-normalization = "0.1"
|
|
# p9-fb-31: GitignoreBuilder for .kebabignore matching in ingest_file_with_config.
|
|
# Same version as kebab-source-fs (0.4) to avoid duplicate dep versions.
|
|
ignore = "0.4"
|
|
# p9-fb-34: opaque pagination cursor encodes payload as base64.
|
|
base64 = { workspace = true }
|
|
|
|
[dev-dependencies]
|
|
rusqlite = { workspace = true }
|
|
tempfile = { workspace = true }
|
|
# Image-pipeline integration tests use wiremock to stub Ollama for OCR
|
|
# / caption HTTP calls. Async runtime to host the mock server only;
|
|
# the kb-app code under test stays sync.
|
|
wiremock = { workspace = true }
|
|
tokio = { workspace = true, features = ["rt-multi-thread"] }
|
|
image = { version = "0.25", default-features = false, features = ["png"] }
|
|
# P7-3 PDF integration tests build in-memory PDF fixtures via the same
|
|
# lopdf builder pattern `kebab-parse-pdf::tests::common` uses; pinned
|
|
# to the same major (0.32) so byte output is identical between the two
|
|
# fixture surfaces.
|
|
lopdf = "0.32"
|
|
# error_wire::tests::llm_unreachable_classifies_to_model_unreachable needs a real
|
|
# reqwest::Error (private constructor) — built from a connect-refused call.
|
|
reqwest = { version = "0.12", default-features = false, features = ["blocking", "rustls-tls"] }
|
|
|
|
[lints]
|
|
workspace = true
|