cut PR v0.18.0 전 마지막 정리. 사용자 요청: "전체 코드베이스를 깔끔하고 알아보기 쉽게".
## Workspace lints
- `Cargo.toml` 의 `[workspace.lints.clippy]` 에 `pedantic = "warn"` (priority -1) + 의도적 allow-list 추가:
- cast_possible_truncation / cast_possible_wrap / cast_sign_loss / cast_precision_loss — ONNX i64 / hash modular reduction 등 의도적 truncation.
- doc_markdown / missing_errors_doc / missing_panics_doc — cosmetic doc style.
- too_many_lines / module_name_repetitions / must_use_candidate / needless_pass_by_value / manual_let_else / items_after_statements / similar_names — informational only.
- format_collect / match_wildcard_for_single_variants / trivially_copy_pass_by_ref / unnecessary_wraps — intentional patterns (exhaustive match, future Result variants 등).
- default_trait_access — `Foo::default()` 가 idiomatic.
- float_cmp — NLI / RRF score 의 explicit threshold 비교 의도.
- struct_excessive_bools / case_sensitive_file_extension_comparisons / naive_bytecount / ignore_without_reason — domain-specific 의도.
- format_push_string / return_self_not_must_use / match_same_arms — builder / wire-label / hot-path 패턴 보존.
- needless_continue / used_underscore_binding / nonminimal_bool / unreadable_literal / many_single_char_names / doc_link_with_quotes / assigning_clones / collapsible_str_replace / trivial_regex / elidable_lifetime_names / range_plus_one / explicit_iter_loop / implicit_hasher / ref_option — remaining low-value style.
- 각 24 crate `Cargo.toml` 에 `[lints] workspace = true` 추가.
## Auto-fix
`cargo clippy --workspace --all-targets --fix` 적용 — 128 files changed, 552 insertions / 472 deletions. 주로:
- uninlined_format_args (~18): `format!("{}", x)` → `format!("{x}")`.
- redundant_closure_for_method_calls (~33): `.map(|x| x.foo())` → `.map(T::foo)`.
- 그 외 mechanical refactor.
## 검증
- `cargo clippy --workspace --all-targets -j 1 -- -D warnings` clean (pedantic + 모든 lint group).
- `cargo test --workspace --no-fail-fast -j 1` — **1293 tests pass + 1 pre-existing flaky fail** (`kebab-mcp::tools_call_ask_multi_hop::ask_tool_routes_multi_hop_true_to_decompose_first`, HOTFIX candidate, cleanup 무관). 회귀 0.
Wire 영향: 없음.
Behavior 영향: 없음 (mechanical refactor only).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
332 lines
12 KiB
Rust
332 lines
12 KiB
Rust
//! Test fixture builders for `kebab-parse-image`.
|
||
//!
|
||
//! Images are generated in-memory at test time rather than committed as
|
||
//! binary fixtures so:
|
||
//!
|
||
//! * The test binary stays self-contained — no `include_bytes!` paths to
|
||
//! keep in sync with the workspace layout.
|
||
//! * Fixture provenance is auditable from source (anyone reading this
|
||
//! module can see exactly what bytes the tests run against).
|
||
//!
|
||
//! All builders are deterministic (no time / RNG dependence).
|
||
|
||
#![allow(dead_code)]
|
||
|
||
use std::io::Cursor;
|
||
|
||
use exif::experimental::Writer as ExifWriter;
|
||
use exif::{Field, In, Rational, Tag, Value};
|
||
use image::{ImageBuffer, Rgb};
|
||
use kebab_core::{
|
||
AssetStorage, Checksum, ExtractConfig, ExtractContext, ImageType, MediaType, RawAsset,
|
||
SourceUri, WorkspacePath,
|
||
};
|
||
use std::path::PathBuf;
|
||
use time::OffsetDateTime;
|
||
|
||
/// 100×50 solid-red PNG, no EXIF.
|
||
pub fn red_100x50_png() -> Vec<u8> {
|
||
let img: ImageBuffer<Rgb<u8>, _> = ImageBuffer::from_fn(100, 50, |_, _| Rgb([255, 0, 0]));
|
||
let mut buf = Cursor::new(Vec::new());
|
||
img.write_to(&mut buf, image::ImageFormat::Png)
|
||
.expect("encoding tiny PNG must not fail");
|
||
buf.into_inner()
|
||
}
|
||
|
||
/// 10×10 solid-blue PNG, no EXIF (smaller fixture for cases where
|
||
/// dimensions don't matter).
|
||
pub fn no_exif_png() -> Vec<u8> {
|
||
let img: ImageBuffer<Rgb<u8>, _> = ImageBuffer::from_fn(10, 10, |_, _| Rgb([0, 0, 255]));
|
||
let mut buf = Cursor::new(Vec::new());
|
||
img.write_to(&mut buf, image::ImageFormat::Png)
|
||
.expect("encoding tiny PNG must not fail");
|
||
buf.into_inner()
|
||
}
|
||
|
||
/// 4000×3000 solid-blue PNG (long edge 4000) used to exercise the OCR
|
||
/// adapter's downscale path. Solid-colour PNGs compress aggressively, so
|
||
/// the on-disk size stays well under 1 MB despite the large dimensions.
|
||
pub fn large_blue_4000x3000_png() -> Vec<u8> {
|
||
let img: ImageBuffer<Rgb<u8>, _> =
|
||
ImageBuffer::from_fn(4000, 3000, |_, _| Rgb([0, 0, 255]));
|
||
let mut buf = Cursor::new(Vec::new());
|
||
img.write_to(&mut buf, image::ImageFormat::Png)
|
||
.expect("encoding 4000x3000 PNG must not fail");
|
||
buf.into_inner()
|
||
}
|
||
|
||
/// PNG with the literal text `"Hello World 2026"` rendered in black
|
||
/// against a white background. Used by the opt-in
|
||
/// `ocr_integration_real_ollama_transcribes_text` integration test —
|
||
/// regular hermetic tests never call it.
|
||
///
|
||
/// Returns `Err` (not panic) if the DejaVu Sans Bold font is missing
|
||
/// from the standard Linux path, so dev boxes without the font can
|
||
/// gracefully skip the integration test rather than crashing the
|
||
/// process.
|
||
pub fn hello_world_png() -> anyhow::Result<Vec<u8>> {
|
||
use ab_glyph::{Font, FontRef, ScaleFont};
|
||
use anyhow::Context;
|
||
|
||
let mut img: ImageBuffer<Rgb<u8>, _> =
|
||
ImageBuffer::from_fn(400, 100, |_, _| Rgb([255, 255, 255]));
|
||
let font_path = "/usr/share/fonts/truetype/dejavu/DejaVuSans-Bold.ttf";
|
||
let font_bytes = std::fs::read(font_path).with_context(|| {
|
||
format!(
|
||
"{font_path} not found — only the opt-in OCR integration fixture needs this font"
|
||
)
|
||
})?;
|
||
let font = FontRef::try_from_slice(&font_bytes).context("DejaVu font parses")?;
|
||
let scaled = font.as_scaled(40.0);
|
||
let text = "Hello World 2026";
|
||
let mut x = 10.0_f32;
|
||
let y = 60.0_f32;
|
||
for ch in text.chars() {
|
||
let glyph = scaled.scaled_glyph(ch);
|
||
if let Some(outlined) = scaled.outline_glyph(glyph.clone()) {
|
||
let bb = outlined.px_bounds();
|
||
outlined.draw(|gx, gy, c| {
|
||
let px = (x + bb.min.x + gx as f32) as i32;
|
||
let py = (y + bb.min.y + gy as f32) as i32;
|
||
if px >= 0 && py >= 0 && (px as u32) < 400 && (py as u32) < 100 {
|
||
let v = ((1.0 - c) * 255.0) as u8;
|
||
img.put_pixel(px as u32, py as u32, Rgb([v, v, v]));
|
||
}
|
||
});
|
||
}
|
||
x += scaled.h_advance(scaled.glyph_id(ch));
|
||
}
|
||
let mut buf = Cursor::new(Vec::new());
|
||
img.write_to(&mut buf, image::ImageFormat::Png)
|
||
.context("encoding hello-world PNG")?;
|
||
Ok(buf.into_inner())
|
||
}
|
||
|
||
/// JPEG with embedded EXIF APP1 segment carrying GPS + Make + Model +
|
||
/// DateTimeOriginal + Orientation + Software. The base image is a 4×4
|
||
/// solid white square — pixel content is irrelevant; the test cares about
|
||
/// the EXIF tags.
|
||
///
|
||
/// Construction: encode JPEG via the `image` crate, then splice an EXIF
|
||
/// APP1 segment immediately after SOI (FF D8). The EXIF blob is built
|
||
/// with `exif::experimental::Writer`.
|
||
pub fn exif_with_gps_jpg() -> Vec<u8> {
|
||
splice_exif_into_jpeg(build_exif_blob_gps(GpsFlavor::Valid))
|
||
}
|
||
|
||
/// JPEG carrying GPSLatitude / GPSLongitude triples but missing the
|
||
/// matching `*Ref` tags. Used to verify the extractor drops the GPS
|
||
/// coordinates entirely (rather than silently assuming positive sign).
|
||
pub fn exif_gps_no_ref_jpg() -> Vec<u8> {
|
||
splice_exif_into_jpeg(build_exif_blob_gps(GpsFlavor::NoRef))
|
||
}
|
||
|
||
/// JPEG carrying a GPSLatitude triple whose decimal value lands outside
|
||
/// the legal `[-90, 90]` range (300° here). Used to verify the extractor
|
||
/// drops the coordinate as corrupted.
|
||
pub fn exif_gps_out_of_range_jpg() -> Vec<u8> {
|
||
splice_exif_into_jpeg(build_exif_blob_gps(GpsFlavor::OutOfRange))
|
||
}
|
||
|
||
fn splice_exif_into_jpeg(exif_blob: Vec<u8>) -> Vec<u8> {
|
||
let base = encode_tiny_jpeg();
|
||
|
||
let mut out = Vec::with_capacity(base.len() + exif_blob.len() + 16);
|
||
// SOI: FF D8.
|
||
out.push(0xFF);
|
||
out.push(0xD8);
|
||
// APP1 marker: FF E1.
|
||
out.push(0xFF);
|
||
out.push(0xE1);
|
||
// APP1 segment length (BE): 2 (length field itself) + 6 ("Exif\0\0")
|
||
// + exif_blob.len(). Pre-validated against the 0xFFFF segment limit.
|
||
let app1_payload_len = 2 + 6 + exif_blob.len();
|
||
assert!(
|
||
u16::try_from(app1_payload_len).is_ok(),
|
||
"EXIF segment too large for a single APP1"
|
||
);
|
||
out.extend_from_slice(&(app1_payload_len as u16).to_be_bytes());
|
||
out.extend_from_slice(b"Exif\x00\x00");
|
||
out.extend_from_slice(&exif_blob);
|
||
// Append the rest of the JPEG starting just after the original SOI.
|
||
out.extend_from_slice(&base[2..]);
|
||
out
|
||
}
|
||
|
||
fn encode_tiny_jpeg() -> Vec<u8> {
|
||
let img: ImageBuffer<Rgb<u8>, _> = ImageBuffer::from_fn(4, 4, |_, _| Rgb([255, 255, 255]));
|
||
let mut buf = Cursor::new(Vec::new());
|
||
img.write_to(&mut buf, image::ImageFormat::Jpeg)
|
||
.expect("encoding tiny JPEG must not fail");
|
||
buf.into_inner()
|
||
}
|
||
|
||
/// Selector for which GPS shape the test fixture should embed.
|
||
#[derive(Clone, Copy)]
|
||
enum GpsFlavor {
|
||
/// 37°30'0" N, 127°0'0" E with both `*Ref` tags (= 37.5, 127.0).
|
||
Valid,
|
||
/// Same DMS triples but `GPSLatitudeRef` / `GPSLongitudeRef` omitted.
|
||
/// Extractor must treat this as corrupted metadata and drop the
|
||
/// coordinates.
|
||
NoRef,
|
||
/// Latitude DMS encodes 300° (out of the legal `[-90, 90]` range).
|
||
/// Extractor must drop the coordinate.
|
||
OutOfRange,
|
||
}
|
||
|
||
fn build_exif_blob_gps(flavor: GpsFlavor) -> Vec<u8> {
|
||
let make = Field {
|
||
tag: Tag::Make,
|
||
ifd_num: In::PRIMARY,
|
||
value: Value::Ascii(vec![b"KebabCam\0".to_vec()]),
|
||
};
|
||
let model = Field {
|
||
tag: Tag::Model,
|
||
ifd_num: In::PRIMARY,
|
||
value: Value::Ascii(vec![b"X1\0".to_vec()]),
|
||
};
|
||
let software = Field {
|
||
tag: Tag::Software,
|
||
ifd_num: In::PRIMARY,
|
||
value: Value::Ascii(vec![b"kebab-test\0".to_vec()]),
|
||
};
|
||
let datetime = Field {
|
||
tag: Tag::DateTimeOriginal,
|
||
ifd_num: In::PRIMARY,
|
||
value: Value::Ascii(vec![b"2024:08:15 12:34:56\0".to_vec()]),
|
||
};
|
||
let orientation = Field {
|
||
tag: Tag::Orientation,
|
||
ifd_num: In::PRIMARY,
|
||
value: Value::Short(vec![1]),
|
||
};
|
||
let (lat_deg, lon_deg) = match flavor {
|
||
GpsFlavor::OutOfRange => (300_u32, 127_u32),
|
||
_ => (37_u32, 127_u32),
|
||
};
|
||
// GPS DMS triples — `OutOfRange` puts 300° in the latitude degrees
|
||
// slot so the resulting decimal escapes ±90.
|
||
let lat = Field {
|
||
tag: Tag::GPSLatitude,
|
||
ifd_num: In::PRIMARY,
|
||
value: Value::Rational(vec![
|
||
Rational { num: lat_deg, denom: 1 },
|
||
Rational { num: 30, denom: 1 },
|
||
Rational { num: 0, denom: 1 },
|
||
]),
|
||
};
|
||
let lat_ref = Field {
|
||
tag: Tag::GPSLatitudeRef,
|
||
ifd_num: In::PRIMARY,
|
||
value: Value::Ascii(vec![b"N\0".to_vec()]),
|
||
};
|
||
let lon = Field {
|
||
tag: Tag::GPSLongitude,
|
||
ifd_num: In::PRIMARY,
|
||
value: Value::Rational(vec![
|
||
Rational { num: lon_deg, denom: 1 },
|
||
Rational { num: 0, denom: 1 },
|
||
Rational { num: 0, denom: 1 },
|
||
]),
|
||
};
|
||
let lon_ref = Field {
|
||
tag: Tag::GPSLongitudeRef,
|
||
ifd_num: In::PRIMARY,
|
||
value: Value::Ascii(vec![b"E\0".to_vec()]),
|
||
};
|
||
|
||
let mut writer = ExifWriter::new();
|
||
writer.push_field(&make);
|
||
writer.push_field(&model);
|
||
writer.push_field(&software);
|
||
writer.push_field(&datetime);
|
||
writer.push_field(&orientation);
|
||
writer.push_field(&lat);
|
||
writer.push_field(&lon);
|
||
if !matches!(flavor, GpsFlavor::NoRef) {
|
||
writer.push_field(&lat_ref);
|
||
writer.push_field(&lon_ref);
|
||
}
|
||
|
||
let mut blob = Cursor::new(Vec::new());
|
||
writer
|
||
.write(&mut blob, false)
|
||
.expect("EXIF writer must succeed for the small whitelisted set");
|
||
blob.into_inner()
|
||
}
|
||
|
||
/// PNG header magic followed by truncated payload. The format guess
|
||
/// succeeds (eight-byte PNG signature is intact) but `into_dimensions`
|
||
/// fails because the IHDR chunk is missing.
|
||
pub fn corrupt_png() -> Vec<u8> {
|
||
// 8-byte PNG signature only — every byte after is missing.
|
||
vec![0x89, 0x50, 0x4E, 0x47, 0x0D, 0x0A, 0x1A, 0x0A]
|
||
}
|
||
|
||
/// Build a `RawAsset` + matching workspace_root + `ExtractContext` for
|
||
/// the test. `bytes_for_id` is hashed (BLAKE3) to produce the AssetId
|
||
/// per §4.2 — this matches what `kebab-source-fs` does in production.
|
||
pub struct ImageFixture {
|
||
pub asset: RawAsset,
|
||
workspace_root: PathBuf,
|
||
config: ExtractConfig,
|
||
}
|
||
|
||
impl ImageFixture {
|
||
pub fn ctx(&self) -> ExtractContext<'_> {
|
||
ExtractContext {
|
||
asset: &self.asset,
|
||
workspace_root: &self.workspace_root,
|
||
config: &self.config,
|
||
}
|
||
}
|
||
}
|
||
|
||
pub fn fixture_for(workspace_path: &str, image_type: ImageType, bytes: &[u8]) -> ImageFixture {
|
||
let blake = blake3::hash(bytes);
|
||
let full_hex = blake.to_hex().to_string();
|
||
let asset_id = kebab_core::id_for_asset(&full_hex);
|
||
let workspace_path = WorkspacePath::new(workspace_path.to_string()).unwrap();
|
||
// Fixed timestamp so determinism tests can compare outputs across runs.
|
||
let discovered_at = OffsetDateTime::from_unix_timestamp(1_700_000_000).unwrap();
|
||
let asset = RawAsset {
|
||
asset_id,
|
||
source_uri: SourceUri::File(PathBuf::from(format!("/tmp/{}", workspace_path.0))),
|
||
workspace_path,
|
||
media_type: MediaType::Image(image_type),
|
||
byte_len: bytes.len() as u64,
|
||
checksum: Checksum(full_hex),
|
||
discovered_at,
|
||
stored: AssetStorage::Reference {
|
||
path: PathBuf::from("/tmp/fake"),
|
||
sha: Checksum("0".repeat(64)),
|
||
},
|
||
};
|
||
ImageFixture {
|
||
asset,
|
||
workspace_root: PathBuf::from("/tmp/fake-root"),
|
||
config: ExtractConfig::default(),
|
||
}
|
||
}
|
||
|
||
/// Strip the two non-deterministic provenance timestamps (Parsed +
|
||
/// optional Warning) so determinism / snapshot tests can compare JSON
|
||
/// without worrying about wall-clock jitter.
|
||
pub fn strip_dynamic_at(json: &mut serde_json::Value) {
|
||
if let Some(events) = json
|
||
.get_mut("provenance")
|
||
.and_then(|p| p.get_mut("events"))
|
||
.and_then(|e| e.as_array_mut())
|
||
{
|
||
for (i, ev) in events.iter_mut().enumerate() {
|
||
if i > 0
|
||
&& let Some(obj) = ev.as_object_mut()
|
||
{
|
||
obj.insert("at".into(), serde_json::Value::String("<stripped>".into()));
|
||
}
|
||
}
|
||
}
|
||
}
|
||
|