First VectorStore implementation. Per-model Lance tables under config.storage.vector_dir, two-phase upsert (SQLite-pending → Lance MergeInsert → SQLite-committed) with crash-safe retry, search via cosine distance with the spec's score-shift (preserves negative similarity ranking signal that clamping would crush). V003 migration: - Adds status (CHECK constraint pending|committed|tombstone, default pending) and vector_committed columns to embedding_records. - BEFORE DELETE trigger on chunks flips dependent rows to tombstone. Currently overshadowed by V001's ON DELETE CASCADE FK; trigger UPDATE runs first then row vanishes via CASCADE. Spec-faithful tombstone preservation requires recreating embedding_records to drop the CASCADE — deferred to a P+ migration since no production rows exist yet (P3-3 is the first writer). V003 SQL comment explains. LanceVectorStore: - ensure_table is idempotent: opens existing or creates with the Arrow schema (chunk_id, doc_id, embedding FixedSizeList<Float32, dim>, model_id, embedding_version, text, heading_path, created_at). - IndexId computed via id_for_index with collection="chunk_embeddings", index_kind="flat", params_hash = blake3(descriptor JSON). Schema bumps automatically rotate the IndexId. - upsert: phase-1 INSERT OR REPLACE INTO embedding_records (status= 'pending') in a single SQLite tx; phase-2 Lance MergeInsert keyed on chunk_id (idempotent re-run); phase-3 UPDATE status='committed', vector_committed=1. If phase-2 fails the rows stay 'pending' and the next upsert call retries idempotently. - search joins embedding_records WHERE status='committed' so partial- write rows never surface. Cosine distance from Lance ∈ [0, 2] → similarity = 1 - distance ∈ [-1, 1] → score = (similarity + 1)/2 ∈ [0, 1]. NaN coerced to 0 with tracing::warn. Filter by SearchFilters via SqliteStore::filter_chunks (added in this commit). - Sync trait + async LanceDB bridged by an embedded current-thread tokio runtime. Doc-comment on the struct flags the "do NOT call from inside another tokio runtime" panic (block_on cannot nest). kb-app's job scheduler is sync today. kb-store-sqlite additions: - pub fn put_embedding_records_pending(&[EmbeddingRecordRow]) — phase-1 INSERT OR REPLACE (status='pending', vector_committed=0). - pub fn mark_embedding_records_committed(&[EmbeddingId]) — phase-3 single UPDATE … WHERE embedding_id IN (?, ?, …) via params_from_iter, guarded by WHERE status='pending' so tombstones don't get clobbered. - pub fn filter_chunks(&[ChunkId], &SearchFilters) → Vec<ChunkId> consolidates the JOIN against documents/document_tags/ embedding_records + path_glob via globset. Lets kb-store-vector honor SearchFilters without depending on rusqlite or globset directly. (kb-search's filter logic is structurally different — interleaved with the FTS5 SELECT — so it stays as-is for now; consolidation is a P+ refactor.) - 4 new unit tests cover the phase-1 round-trip, empty batch, replay reset of pending rows, and the WHERE-status-pending guard. Tests: - 9 lib unit tests in kb-store-vector covering paths/sanitization, arrow_batch dim validation + descriptor hash, bm25-style cosine score shift math. - 4 new kb-store-sqlite unit tests on filter_chunks (committed-only, tags/lang/trust/path_glob, order preservation, empty input). - 4 new kb-store-sqlite unit tests on the embedding_records helpers. - 8 integration tests in upsert_search.rs and 1 snapshot test marked #[ignore = "requires AVX-capable hardware (LanceDB)"]. They invoke require_avx_or_panic() at the top of each body so a missing-AVX --ignored run fails loudly instead of silently passing. This dev host (qemu64 model) lacks AVX so these were NOT exercised end-to- end here — first CI lane on AVX hardware will validate them. - Snapshot fixture tests/fixtures/vector/run-1.json is a placeholder with an _comment marker. Snapshot test panics until the placeholder is replaced via KB_UPDATE_SNAPSHOTS=1 on AVX hardware. - Workspace 241 passed, 19 ignored, 0 failed; cargo clippy --workspace --all-targets -- -D warnings clean. Allowed deps respected (kb-core, kb-config, kb-store-sqlite, lancedb, arrow + arrow-array + arrow-schema, serde, serde_json, tracing, thiserror) plus forced waivers — anyhow (trait return type), tokio + futures (LanceDB async-only API), blake3 (params_hash). rusqlite and globset are NOT direct deps of kb-store-vector — confirmed via cargo metadata --no-deps. rusqlite stays in [dev-dependencies] for the test fixture seeder only. Out of scope: IVF/PQ index tuning (P+), image vectors (P6), kb-app embed_index orchestration (P3-4 facade). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
186 lines
6.7 KiB
Rust
186 lines
6.7 KiB
Rust
//! Shared scaffolding for kb-store-vector integration tests.
|
|
//!
|
|
//! # Test policy
|
|
//!
|
|
//! Integration tests in this crate are marked `#[ignore]` and require
|
|
//! AVX-capable hardware. They are excluded from the default `cargo
|
|
//! test -p kb-store-vector` lane and only run when explicitly opted
|
|
//! in:
|
|
//!
|
|
//! ```text
|
|
//! cargo test -p kb-store-vector -- --ignored
|
|
//! ```
|
|
//!
|
|
//! The reason: LanceDB's f32 SIMD path uses unconditional AVX
|
|
//! intrinsics (`__m256` in `lance-linalg::simd::f32`). On x86_64
|
|
//! CPUs without AVX support — notably QEMU's default `qemu64` model
|
|
//! in CI sandboxes and some bare-metal dev boxes — those instructions
|
|
//! trigger `SIGILL: illegal instruction` at the first `vector_search`
|
|
//! call. Rather than silently turn that into a "passing" test (which
|
|
//! it isn't), we gate the integration suite behind `#[ignore]` and
|
|
//! call [`require_avx_or_panic`] inside each test body so that an
|
|
//! `--ignored` invocation on a non-AVX host fails loudly rather than
|
|
//! crashing later inside a Lance kernel.
|
|
//!
|
|
//! This mirrors P3-2's `#[ignore]` policy on tests that require a
|
|
//! model download — both are CI-lane decisions, not silent skips.
|
|
//!
|
|
//! Each test owns a `TempDir` (vector_dir + sqlite db live underneath
|
|
//! it), a fully-migrated `SqliteStore`, and a `LanceVectorStore`
|
|
//! pointed at both. We seed `documents` / `chunks` rows directly via
|
|
//! SQL (rather than going through `DocumentStore::put_document`) so
|
|
//! the tests stay independent of kb-parse-md / kb-normalize / kb-chunk
|
|
//! and so we can construct adversarial fixtures (filtered tags,
|
|
//! mismatched langs) without reproducing a Markdown round-trip.
|
|
|
|
#![allow(dead_code)]
|
|
|
|
use std::path::PathBuf;
|
|
use std::sync::Arc;
|
|
|
|
/// Panic if the host CPU lacks AVX. Called from every `#[ignore]`-d
|
|
/// integration test body so that `cargo test -- --ignored` on a
|
|
/// non-AVX host fails loudly with a clear message instead of crashing
|
|
/// later inside a Lance SIMD kernel with `SIGILL`.
|
|
///
|
|
/// On non-x86_64 hosts this is a no-op (Lance's AVX requirement is
|
|
/// x86-only — ARM/Apple Silicon paths use different intrinsics that
|
|
/// the workspace doesn't currently target).
|
|
pub fn require_avx_or_panic() {
|
|
#[cfg(target_arch = "x86_64")]
|
|
{
|
|
if !std::is_x86_feature_detected!("avx") {
|
|
panic!(
|
|
"kb-store-vector integration test requires AVX-capable hardware; \
|
|
host CPU lacks AVX. Run on an AVX-capable machine. \
|
|
See crates/kb-store-vector/tests/common/mod.rs."
|
|
);
|
|
}
|
|
}
|
|
}
|
|
|
|
use kb_config::Config;
|
|
use kb_core::{
|
|
ChunkId, DocumentId, EmbeddingId, EmbeddingModelId, EmbeddingVersion, VectorRecord,
|
|
};
|
|
use kb_store_sqlite::SqliteStore;
|
|
use kb_store_vector::LanceVectorStore;
|
|
use rusqlite::params;
|
|
use tempfile::TempDir;
|
|
|
|
pub struct TestEnv {
|
|
pub temp: TempDir,
|
|
pub config: Config,
|
|
pub sqlite: Arc<SqliteStore>,
|
|
pub vector: LanceVectorStore,
|
|
}
|
|
|
|
impl TestEnv {
|
|
pub fn new() -> Self {
|
|
let temp = tempfile::tempdir().expect("tempdir");
|
|
let mut config = Config::defaults();
|
|
config.storage.data_dir = temp.path().to_string_lossy().into_owned();
|
|
let sqlite = SqliteStore::open(&config).unwrap();
|
|
sqlite.run_migrations().unwrap();
|
|
let sqlite = Arc::new(sqlite);
|
|
let vector = LanceVectorStore::new(&config, sqlite.clone()).unwrap();
|
|
Self {
|
|
temp,
|
|
config,
|
|
sqlite,
|
|
vector,
|
|
}
|
|
}
|
|
|
|
pub fn data_dir(&self) -> PathBuf {
|
|
self.temp.path().to_path_buf()
|
|
}
|
|
|
|
/// Insert minimum (asset, document, chunk) rows so phase-1
|
|
/// embedding_records inserts don't trip the FK to chunks /
|
|
/// documents.
|
|
pub fn seed_chunk(
|
|
&self,
|
|
chunk_id: &str,
|
|
doc_id: &str,
|
|
workspace_path: &str,
|
|
lang: &str,
|
|
tags: &[&str],
|
|
trust_level: &str,
|
|
) {
|
|
// Asset id derived from doc_id deterministically — every
|
|
// chunk gets its own asset to keep things simple.
|
|
let asset_id = format!("a{}", &doc_id[..31]);
|
|
let conn = self.sqlite.read_conn();
|
|
conn.execute(
|
|
"INSERT OR IGNORE INTO assets (
|
|
asset_id, source_uri, workspace_path, media_type, byte_len,
|
|
checksum, storage_kind, storage_path, discovered_at
|
|
) VALUES (?, ?, ?, ?, 0, ?, 'reference', ?, '1970-01-01T00:00:00Z')",
|
|
params![
|
|
asset_id,
|
|
format!("file://{workspace_path}"),
|
|
workspace_path,
|
|
"{}",
|
|
"deadbeefdeadbeefdeadbeefdeadbeef",
|
|
workspace_path,
|
|
],
|
|
)
|
|
.unwrap();
|
|
conn.execute(
|
|
"INSERT OR IGNORE INTO documents (
|
|
doc_id, asset_id, workspace_path, title, lang, source_type,
|
|
trust_level, parser_version, doc_version, schema_version,
|
|
metadata_json, provenance_json, created_at, updated_at
|
|
) VALUES (?, ?, ?, NULL, ?, 'markdown', ?, 'v1', 1, 1, '{}', '{}',
|
|
'1970-01-01T00:00:00Z', '1970-01-01T00:00:00Z')",
|
|
params![doc_id, asset_id, workspace_path, lang, trust_level],
|
|
)
|
|
.unwrap();
|
|
for t in tags {
|
|
conn.execute(
|
|
"INSERT OR IGNORE INTO document_tags (doc_id, tag) VALUES (?, ?)",
|
|
params![doc_id, t],
|
|
)
|
|
.unwrap();
|
|
}
|
|
conn.execute(
|
|
"INSERT OR IGNORE INTO chunks (
|
|
chunk_id, doc_id, text, heading_path_json, section_label,
|
|
source_spans_json, token_estimate, chunker_version,
|
|
policy_hash, block_ids_json, created_at
|
|
) VALUES (?, ?, 'hi', '[]', NULL, '[]', 1, 'v1', 'h', '[]', '1970-01-01T00:00:00Z')",
|
|
params![chunk_id, doc_id],
|
|
)
|
|
.unwrap();
|
|
}
|
|
}
|
|
|
|
/// Build a deterministic test VectorRecord from a few simple inputs.
|
|
/// `vector` is taken verbatim, `dimensions` is set from `vector.len()`.
|
|
pub fn make_record(
|
|
chunk_idx: u8,
|
|
doc_idx: u8,
|
|
vector: Vec<f32>,
|
|
text: &str,
|
|
heading: &[&str],
|
|
model: &str,
|
|
) -> VectorRecord {
|
|
let dim = vector.len();
|
|
let chunk_id = ChunkId(format!("{:032x}", 0x1100u32 + chunk_idx as u32));
|
|
let doc_id = DocumentId(format!("{:032x}", 0xd0c0u32 + doc_idx as u32));
|
|
let embedding_id =
|
|
EmbeddingId(format!("{:032x}", 0xeeee0000u32 + chunk_idx as u32));
|
|
VectorRecord {
|
|
chunk_id,
|
|
embedding_id,
|
|
vector,
|
|
doc_id,
|
|
text: text.to_string(),
|
|
heading_path: heading.iter().map(|s| s.to_string()).collect(),
|
|
model_id: EmbeddingModelId(model.to_string()),
|
|
model_version: EmbeddingVersion("v1".to_string()),
|
|
dimensions: dim,
|
|
}
|
|
}
|