altair823
7c85de065a
cut PR v0.18.0 전 마지막 정리. 사용자 요청: "전체 코드베이스를 깔끔하고 알아보기 쉽게".
## Workspace lints
- `Cargo.toml` 의 `[workspace.lints.clippy]` 에 `pedantic = "warn"` (priority -1) + 의도적 allow-list 추가:
- cast_possible_truncation / cast_possible_wrap / cast_sign_loss / cast_precision_loss — ONNX i64 / hash modular reduction 등 의도적 truncation.
- doc_markdown / missing_errors_doc / missing_panics_doc — cosmetic doc style.
- too_many_lines / module_name_repetitions / must_use_candidate / needless_pass_by_value / manual_let_else / items_after_statements / similar_names — informational only.
- format_collect / match_wildcard_for_single_variants / trivially_copy_pass_by_ref / unnecessary_wraps — intentional patterns (exhaustive match, future Result variants 등).
- default_trait_access — `Foo::default()` 가 idiomatic.
- float_cmp — NLI / RRF score 의 explicit threshold 비교 의도.
- struct_excessive_bools / case_sensitive_file_extension_comparisons / naive_bytecount / ignore_without_reason — domain-specific 의도.
- format_push_string / return_self_not_must_use / match_same_arms — builder / wire-label / hot-path 패턴 보존.
- needless_continue / used_underscore_binding / nonminimal_bool / unreadable_literal / many_single_char_names / doc_link_with_quotes / assigning_clones / collapsible_str_replace / trivial_regex / elidable_lifetime_names / range_plus_one / explicit_iter_loop / implicit_hasher / ref_option — remaining low-value style.
- 각 24 crate `Cargo.toml` 에 `[lints] workspace = true` 추가.
## Auto-fix
`cargo clippy --workspace --all-targets --fix` 적용 — 128 files changed, 552 insertions / 472 deletions. 주로:
- uninlined_format_args (~18): `format!("{}", x)` → `format!("{x}")`.
- redundant_closure_for_method_calls (~33): `.map(|x| x.foo())` → `.map(T::foo)`.
- 그 외 mechanical refactor.
## 검증
- `cargo clippy --workspace --all-targets -j 1 -- -D warnings` clean (pedantic + 모든 lint group).
- `cargo test --workspace --no-fail-fast -j 1` — **1293 tests pass + 1 pre-existing flaky fail** (`kebab-mcp::tools_call_ask_multi_hop::ask_tool_routes_multi_hop_true_to_decompose_first`, HOTFIX candidate, cleanup 무관). 회귀 0.
Wire 영향: 없음.
Behavior 영향: 없음 (mechanical refactor only).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
78 lines
2.6 KiB
Rust
78 lines
2.6 KiB
Rust
//! Spawn `target/debug/kebab mcp` and exercise initialize → tools/list.
|
|
//!
|
|
//! rmcp 1.6 has no public in-memory test transport, so this is the only
|
|
//! end-to-end MCP assertion in the suite. The binary is located via
|
|
//! `CARGO_BIN_EXE_kebab` which cargo injects at test compile time.
|
|
|
|
use std::io::{BufRead, BufReader, Write};
|
|
use std::process::{Command, Stdio};
|
|
|
|
#[test]
|
|
fn cli_mcp_initialize_then_tools_list() {
|
|
let bin = env!("CARGO_BIN_EXE_kebab");
|
|
let mut child = Command::new(bin)
|
|
.arg("mcp")
|
|
.stdin(Stdio::piped())
|
|
.stdout(Stdio::piped())
|
|
.stderr(Stdio::null())
|
|
.spawn()
|
|
.unwrap();
|
|
|
|
let mut stdin = child.stdin.take().unwrap();
|
|
let stdout = child.stdout.take().unwrap();
|
|
let mut reader = BufReader::new(stdout);
|
|
|
|
// rmcp 1.6 defaults to protocol version "2025-03-26" (confirmed by
|
|
// manual smoke in Task 10). The server echoes whatever version the
|
|
// client sends during the handshake, so this literal must match.
|
|
let init_req = r#"{"jsonrpc":"2.0","id":1,"method":"initialize","params":{"protocolVersion":"2025-03-26","capabilities":{},"clientInfo":{"name":"test","version":"0"}}}"#;
|
|
writeln!(stdin, "{init_req}").unwrap();
|
|
writeln!(
|
|
stdin,
|
|
r#"{{"jsonrpc":"2.0","method":"notifications/initialized"}}"#
|
|
)
|
|
.unwrap();
|
|
writeln!(
|
|
stdin,
|
|
r#"{{"jsonrpc":"2.0","id":2,"method":"tools/list","params":{{}}}}"#
|
|
)
|
|
.unwrap();
|
|
|
|
// Read initialize response.
|
|
let mut line = String::new();
|
|
reader.read_line(&mut line).unwrap();
|
|
let init: serde_json::Value = serde_json::from_str(line.trim()).unwrap();
|
|
assert_eq!(
|
|
init.get("id").and_then(serde_json::Value::as_i64),
|
|
Some(1),
|
|
"unexpected id in initialize response: {init}"
|
|
);
|
|
assert!(
|
|
init.get("result").is_some(),
|
|
"initialize result missing: {init}"
|
|
);
|
|
|
|
// Read tools/list response.
|
|
line.clear();
|
|
reader.read_line(&mut line).unwrap();
|
|
let list: serde_json::Value = serde_json::from_str(line.trim()).unwrap();
|
|
assert_eq!(
|
|
list.get("id").and_then(serde_json::Value::as_i64),
|
|
Some(2),
|
|
"unexpected id in tools/list response: {list}"
|
|
);
|
|
let tools = list["result"]["tools"]
|
|
.as_array()
|
|
.expect("tools/list result.tools must be an array");
|
|
assert_eq!(
|
|
tools.len(),
|
|
8,
|
|
"expected 8 tools (schema, doctor, search, bulk_search, ask, fetch, ingest_file, ingest_stdin), got {}: {list}",
|
|
tools.len()
|
|
);
|
|
|
|
// Gracefully close stdin so the server shuts down cleanly.
|
|
drop(stdin);
|
|
let _ = child.wait().unwrap();
|
|
}
|