altair823
6a9551e0fa
Round 3 final dogfood (2026-05-28) 에서 60s default 가 dense Korean page (metro-korea.pdf page 8/9/13) 의 OCR 을 강제 timeout — round 2 대비 1 page 더 indexed 손실. user perspective: cost vs coverage trade-off 가 60s 에선 coverage 쪽으로 너무 깎임. Sweet spot 점진적 축소 정책 채택 — conservative starting point 180s 부터 dogfood evidence (OCR 평균 ms 분포) 기반 점진적 축소. 60s 같은 짧은 default 로 직접 jump 안 함. - crates/kebab-config/src/lib.rs::default_pdf_ocr_request_timeout_secs() = 180 - unit test rename (_is_60s → _is_180s) + assertion 180 - crates/kebab-config/tests/pdf_ocr.rs assert_eq 180 - tasks/HOTFIXES.md 2026-05-28 follow-up entry 추가 User override path 보존 — config.toml [pdf.ocr] request_timeout_secs = N 로 user 가 직접 tune. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
81 lines
3.0 KiB
Rust
81 lines
3.0 KiB
Rust
// crates/kebab-config/tests/pdf_ocr.rs
|
|
//
|
|
// Integration tests for [pdf.ocr] config section (v0.20.0 sub-item 1).
|
|
|
|
use std::collections::HashMap;
|
|
use kebab_config::{Config, PdfCfg};
|
|
|
|
// Test 1: toml roundtrip — spec §4.5 line 1034-1047 example block.
|
|
// Config requires many required fields; test the [pdf] section via PdfCfg wrapper.
|
|
#[derive(serde::Deserialize)]
|
|
struct PdfWrapper { pdf: PdfCfg }
|
|
|
|
#[test]
|
|
fn pdf_ocr_toml_roundtrip() {
|
|
let toml = r#"
|
|
[pdf.ocr]
|
|
enabled = true
|
|
always_on = false
|
|
engine = "ollama-vision"
|
|
model = "qwen2.5vl:7b"
|
|
endpoint = "http://192.168.0.47:11434"
|
|
languages = ["eng", "kor"]
|
|
max_pixels = 3072
|
|
request_timeout_secs = 900
|
|
valid_ratio_threshold = 0.6
|
|
min_char_count = 30
|
|
lang_hint = "kor"
|
|
"#;
|
|
let w: PdfWrapper = toml::from_str(toml).expect("parse toml");
|
|
let ocr = &w.pdf.ocr;
|
|
assert!(ocr.enabled);
|
|
assert!(!ocr.always_on);
|
|
assert_eq!(ocr.engine, "ollama-vision");
|
|
assert_eq!(ocr.model, "qwen2.5vl:7b");
|
|
assert_eq!(ocr.endpoint.as_deref(), Some("http://192.168.0.47:11434"));
|
|
assert_eq!(ocr.languages, vec!["eng".to_string(), "kor".to_string()]);
|
|
assert_eq!(ocr.max_pixels, 3072);
|
|
assert_eq!(ocr.request_timeout_secs, 900);
|
|
assert!((ocr.valid_ratio_threshold - 0.6).abs() < 1e-6);
|
|
assert_eq!(ocr.min_char_count, 30);
|
|
assert_eq!(ocr.lang_hint.as_deref(), Some("kor"));
|
|
}
|
|
|
|
// Test 2: defaults — opt-in, qwen2.5vl:3b model, 0.5 threshold, 20 min_char.
|
|
#[test]
|
|
fn pdf_ocr_defaults_off_with_qwen_3b() {
|
|
let cfg = Config::defaults();
|
|
assert!(!cfg.pdf.ocr.enabled);
|
|
assert!(!cfg.pdf.ocr.always_on);
|
|
assert_eq!(cfg.pdf.ocr.engine, "ollama-vision");
|
|
assert_eq!(cfg.pdf.ocr.model, "qwen2.5vl:3b");
|
|
assert!(cfg.pdf.ocr.endpoint.is_none());
|
|
assert_eq!(cfg.pdf.ocr.languages, vec!["eng".to_string(), "kor".to_string()]);
|
|
assert_eq!(cfg.pdf.ocr.max_pixels, 2048);
|
|
assert_eq!(cfg.pdf.ocr.request_timeout_secs, 180); // Bug #11: 600 → 60 → 180 (HOTFIXES 2026-05-28)
|
|
assert!((cfg.pdf.ocr.valid_ratio_threshold - 0.5).abs() < 1e-6);
|
|
assert_eq!(cfg.pdf.ocr.min_char_count, 20);
|
|
assert_eq!(cfg.pdf.ocr.lang_hint.as_deref(), Some("kor"));
|
|
}
|
|
|
|
// Test 3: env var override — 4 keys 의 typical override case.
|
|
#[test]
|
|
fn pdf_ocr_env_overrides() {
|
|
let mut env: HashMap<String, String> = HashMap::new();
|
|
env.insert("KEBAB_PDF_OCR_ENABLED".to_string(), "true".to_string());
|
|
env.insert("KEBAB_PDF_OCR_MODEL".to_string(), "qwen2.5vl:7b".to_string());
|
|
env.insert("KEBAB_PDF_OCR_ALWAYS_ON".to_string(), "true".to_string());
|
|
env.insert("KEBAB_PDF_OCR_VALID_RATIO_THRESHOLD".to_string(), "0.75".to_string());
|
|
|
|
let cfg = Config::defaults().apply_env(&env);
|
|
|
|
assert!(cfg.pdf.ocr.enabled);
|
|
assert_eq!(cfg.pdf.ocr.model, "qwen2.5vl:7b");
|
|
assert!(cfg.pdf.ocr.always_on);
|
|
assert!((cfg.pdf.ocr.valid_ratio_threshold - 0.75).abs() < 1e-6);
|
|
|
|
// 다른 env var 가 default 보존
|
|
assert_eq!(cfg.pdf.ocr.engine, "ollama-vision");
|
|
assert_eq!(cfg.pdf.ocr.min_char_count, 20);
|
|
}
|