altair823
7c85de065a
cut PR v0.18.0 전 마지막 정리. 사용자 요청: "전체 코드베이스를 깔끔하고 알아보기 쉽게".
## Workspace lints
- `Cargo.toml` 의 `[workspace.lints.clippy]` 에 `pedantic = "warn"` (priority -1) + 의도적 allow-list 추가:
- cast_possible_truncation / cast_possible_wrap / cast_sign_loss / cast_precision_loss — ONNX i64 / hash modular reduction 등 의도적 truncation.
- doc_markdown / missing_errors_doc / missing_panics_doc — cosmetic doc style.
- too_many_lines / module_name_repetitions / must_use_candidate / needless_pass_by_value / manual_let_else / items_after_statements / similar_names — informational only.
- format_collect / match_wildcard_for_single_variants / trivially_copy_pass_by_ref / unnecessary_wraps — intentional patterns (exhaustive match, future Result variants 등).
- default_trait_access — `Foo::default()` 가 idiomatic.
- float_cmp — NLI / RRF score 의 explicit threshold 비교 의도.
- struct_excessive_bools / case_sensitive_file_extension_comparisons / naive_bytecount / ignore_without_reason — domain-specific 의도.
- format_push_string / return_self_not_must_use / match_same_arms — builder / wire-label / hot-path 패턴 보존.
- needless_continue / used_underscore_binding / nonminimal_bool / unreadable_literal / many_single_char_names / doc_link_with_quotes / assigning_clones / collapsible_str_replace / trivial_regex / elidable_lifetime_names / range_plus_one / explicit_iter_loop / implicit_hasher / ref_option — remaining low-value style.
- 각 24 crate `Cargo.toml` 에 `[lints] workspace = true` 추가.
## Auto-fix
`cargo clippy --workspace --all-targets --fix` 적용 — 128 files changed, 552 insertions / 472 deletions. 주로:
- uninlined_format_args (~18): `format!("{}", x)` → `format!("{x}")`.
- redundant_closure_for_method_calls (~33): `.map(|x| x.foo())` → `.map(T::foo)`.
- 그 외 mechanical refactor.
## 검증
- `cargo clippy --workspace --all-targets -j 1 -- -D warnings` clean (pedantic + 모든 lint group).
- `cargo test --workspace --no-fail-fast -j 1` — **1293 tests pass + 1 pre-existing flaky fail** (`kebab-mcp::tools_call_ask_multi_hop::ask_tool_routes_multi_hop_true_to_decompose_first`, HOTFIX candidate, cleanup 무관). 회귀 0.
Wire 영향: 없음.
Behavior 영향: 없음 (mechanical refactor only).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
88 lines
3.2 KiB
Rust
88 lines
3.2 KiB
Rust
//! Vector / Hybrid lane — AVX-gated. Marked `#[ignore]` because Lance
|
|
//! crashes with `SIGILL` on hosts without AVX, and CI lanes that are
|
|
//! AVX-less should not run these. Local hosts run them via
|
|
//! `cargo test -p kb-app -- --ignored`.
|
|
|
|
mod common;
|
|
|
|
use common::TestEnv;
|
|
|
|
/// Panic if the host CPU lacks AVX. Mirrors the helper in
|
|
/// `kb-store-vector/tests/common/mod.rs` and `kb-search` so a
|
|
/// `--ignored` invocation on a non-AVX host fails loudly with a
|
|
/// clear message instead of crashing inside Lance's SIMD kernel.
|
|
fn require_avx_or_panic() {
|
|
#[cfg(target_arch = "x86_64")]
|
|
{
|
|
assert!(std::is_x86_feature_detected!("avx"),
|
|
"kb-app vector integration test requires AVX-capable hardware; \
|
|
host CPU lacks AVX. Run on an AVX-capable machine."
|
|
);
|
|
}
|
|
}
|
|
|
|
// First run downloads ~470MB; expect ~30-60s warm, several minutes cold.
|
|
#[test]
|
|
#[ignore = "AVX-required (Lance SIMD kernels)"]
|
|
fn ingest_then_hybrid_search_returns_hits() {
|
|
require_avx_or_panic();
|
|
|
|
let env = TestEnv::with_embeddings();
|
|
let report =
|
|
kebab_app::ingest_with_config(env.config.clone(), env.scope(), true).unwrap();
|
|
assert_eq!(report.errors, 0, "no per-file errors: {report:?}");
|
|
assert_eq!(report.new, 3);
|
|
|
|
let q = kebab_core::SearchQuery {
|
|
text: "ownership".to_string(),
|
|
mode: kebab_core::SearchMode::Hybrid,
|
|
k: 10,
|
|
filters: kebab_core::SearchFilters::default(),
|
|
};
|
|
let hits = kebab_app::search_with_config(env.config.clone(), q).unwrap();
|
|
assert!(!hits.is_empty(), "expected hybrid hits for 'ownership'");
|
|
let methods: Vec<_> = hits.iter().map(|h| h.retrieval.method).collect();
|
|
assert!(
|
|
methods.iter().all(|m| *m == kebab_core::SearchMode::Hybrid),
|
|
"every hit must report method=Hybrid: {methods:?}"
|
|
);
|
|
}
|
|
|
|
// First run downloads ~470MB; expect ~30-60s warm, several minutes cold.
|
|
#[test]
|
|
#[ignore = "AVX-required (Lance SIMD kernels)"]
|
|
fn ingest_then_vector_search_carries_embedding_model() {
|
|
require_avx_or_panic();
|
|
|
|
let env = TestEnv::with_embeddings();
|
|
let report =
|
|
kebab_app::ingest_with_config(env.config.clone(), env.scope(), true).unwrap();
|
|
assert_eq!(report.errors, 0, "no per-file errors: {report:?}");
|
|
assert_eq!(report.new, 3);
|
|
|
|
let q = kebab_core::SearchQuery {
|
|
text: "ownership".to_string(),
|
|
mode: kebab_core::SearchMode::Vector,
|
|
k: 10,
|
|
filters: kebab_core::SearchFilters::default(),
|
|
};
|
|
let hits = kebab_app::search_with_config(env.config.clone(), q).unwrap();
|
|
assert!(!hits.is_empty(), "expected vector hits for 'ownership'");
|
|
|
|
// Vector mode dispatches through `VectorRetriever` and MUST stamp
|
|
// each hit with the configured embedding_model id.
|
|
let expected = kebab_core::EmbeddingModelId(env.config.models.embedding.model.clone());
|
|
for h in &hits {
|
|
assert_eq!(
|
|
h.embedding_model,
|
|
Some(expected.clone()),
|
|
"vector-mode hit must carry embedding_model={expected:?}: {h:?}"
|
|
);
|
|
assert_eq!(
|
|
h.retrieval.method,
|
|
kebab_core::SearchMode::Vector,
|
|
"vector-mode hit must report method=Vector"
|
|
);
|
|
}
|
|
}
|