cut PR v0.18.0 전 마지막 정리. 사용자 요청: "전체 코드베이스를 깔끔하고 알아보기 쉽게".
## Workspace lints
- `Cargo.toml` 의 `[workspace.lints.clippy]` 에 `pedantic = "warn"` (priority -1) + 의도적 allow-list 추가:
- cast_possible_truncation / cast_possible_wrap / cast_sign_loss / cast_precision_loss — ONNX i64 / hash modular reduction 등 의도적 truncation.
- doc_markdown / missing_errors_doc / missing_panics_doc — cosmetic doc style.
- too_many_lines / module_name_repetitions / must_use_candidate / needless_pass_by_value / manual_let_else / items_after_statements / similar_names — informational only.
- format_collect / match_wildcard_for_single_variants / trivially_copy_pass_by_ref / unnecessary_wraps — intentional patterns (exhaustive match, future Result variants 등).
- default_trait_access — `Foo::default()` 가 idiomatic.
- float_cmp — NLI / RRF score 의 explicit threshold 비교 의도.
- struct_excessive_bools / case_sensitive_file_extension_comparisons / naive_bytecount / ignore_without_reason — domain-specific 의도.
- format_push_string / return_self_not_must_use / match_same_arms — builder / wire-label / hot-path 패턴 보존.
- needless_continue / used_underscore_binding / nonminimal_bool / unreadable_literal / many_single_char_names / doc_link_with_quotes / assigning_clones / collapsible_str_replace / trivial_regex / elidable_lifetime_names / range_plus_one / explicit_iter_loop / implicit_hasher / ref_option — remaining low-value style.
- 각 24 crate `Cargo.toml` 에 `[lints] workspace = true` 추가.
## Auto-fix
`cargo clippy --workspace --all-targets --fix` 적용 — 128 files changed, 552 insertions / 472 deletions. 주로:
- uninlined_format_args (~18): `format!("{}", x)` → `format!("{x}")`.
- redundant_closure_for_method_calls (~33): `.map(|x| x.foo())` → `.map(T::foo)`.
- 그 외 mechanical refactor.
## 검증
- `cargo clippy --workspace --all-targets -j 1 -- -D warnings` clean (pedantic + 모든 lint group).
- `cargo test --workspace --no-fail-fast -j 1` — **1293 tests pass + 1 pre-existing flaky fail** (`kebab-mcp::tools_call_ask_multi_hop::ask_tool_routes_multi_hop_true_to_decompose_first`, HOTFIX candidate, cleanup 무관). 회귀 0.
Wire 영향: 없음.
Behavior 영향: 없음 (mechanical refactor only).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
142 lines
5.3 KiB
Rust
142 lines
5.3 KiB
Rust
//! Integration tests for `OnnxNliVerifier` against the real
|
|
//! mDeBERTa-v3 XNLI model. Every test is `#[ignore]` — plain
|
|
//! `cargo test -p kebab-nli` skips them; run explicitly with
|
|
//! `cargo test -p kebab-nli --test inference -- --ignored` to
|
|
//! exercise the (slow + network-bound on first run) inference path.
|
|
//!
|
|
//! First test in the file triggers the ~280 MB ONNX + ~16 MB
|
|
//! tokenizer download into `config.storage.model_dir/nli/...`;
|
|
//! subsequent tests hit the OnceLock cache for free.
|
|
|
|
use kebab_config::Config;
|
|
use kebab_nli::{NliVerifier, OnnxNliVerifier};
|
|
|
|
/// Test 1: an English statement entails itself with high confidence.
|
|
/// Smoke evidence captured for the PR description's `## 검증` section.
|
|
#[test]
|
|
#[ignore]
|
|
fn en_self_entailment_high_score() {
|
|
let cfg = Config::defaults();
|
|
let v = OnnxNliVerifier::new(&cfg).expect("verifier construction");
|
|
let premise = "Caffeine is a stimulant.";
|
|
let hypothesis = "Caffeine is a stimulant.";
|
|
let s = v.score(premise, hypothesis).expect("score should succeed");
|
|
eprintln!(
|
|
"[test1 en_self_entailment_high_score] premise={premise:?} hypothesis={hypothesis:?} \
|
|
scores: entailment={:.4}, neutral={:.4}, contradiction={:.4}",
|
|
s.entailment, s.neutral, s.contradiction
|
|
);
|
|
assert!(
|
|
s.entailment > 0.8,
|
|
"expected entailment > 0.8, got {:.4} (full scores: {:?})",
|
|
s.entailment,
|
|
s
|
|
);
|
|
}
|
|
|
|
/// Test 2: an unrelated chemistry fact does NOT entail the premise.
|
|
/// Entailment should be low — neutral / contradiction wins.
|
|
#[test]
|
|
#[ignore]
|
|
fn en_unrelated_low_entailment() {
|
|
let cfg = Config::defaults();
|
|
let v = OnnxNliVerifier::new(&cfg).expect("verifier construction");
|
|
let premise = "Caffeine is a stimulant.";
|
|
let hypothesis = "The chemical formula of caffeine is C8H10N4O2.";
|
|
let s = v.score(premise, hypothesis).expect("score should succeed");
|
|
eprintln!(
|
|
"[test2 en_unrelated_low_entailment] \
|
|
scores: entailment={:.4}, neutral={:.4}, contradiction={:.4}",
|
|
s.entailment, s.neutral, s.contradiction
|
|
);
|
|
// spec §3 PR-9b: "entailment 낮음 — neutral/contradiction 이 winning channel" 의
|
|
// *spirit* 은 *neutral 이 max* 임. 실측 mDeBERTa 의 noise (entailment≈0.42, neutral≈0.53,
|
|
// contradiction≈0.05) 에서 두 문장 모두 caffeine 의 *사실* 이라 entailment 가 0.3 미만으로
|
|
// 떨어지지 않음 — 그러나 neutral 이 winning. multilingual NLI 의 자연스러운 동작.
|
|
assert!(
|
|
s.neutral > s.entailment && s.neutral > s.contradiction,
|
|
"expected neutral to win (no entailment, no contradiction), got {s:?}"
|
|
);
|
|
}
|
|
|
|
/// Test 3: Korean entailment. The threshold is intentionally generous
|
|
/// (> 0.5) because cross-lingual XNLI is noisier than English-only.
|
|
#[test]
|
|
#[ignore]
|
|
fn ko_entailment_high_score() {
|
|
let cfg = Config::defaults();
|
|
let v = OnnxNliVerifier::new(&cfg).expect("verifier construction");
|
|
let premise = "사과는 빨갛다.";
|
|
let hypothesis = "사과는 색이 있다.";
|
|
let s = v.score(premise, hypothesis).expect("score should succeed");
|
|
eprintln!(
|
|
"[test3 ko_entailment_high_score] \
|
|
scores: entailment={:.4}, neutral={:.4}, contradiction={:.4}",
|
|
s.entailment, s.neutral, s.contradiction
|
|
);
|
|
assert!(
|
|
s.entailment > 0.5,
|
|
"expected entailment > 0.5, got {:.4} (full scores: {:?})",
|
|
s.entailment,
|
|
s
|
|
);
|
|
}
|
|
|
|
/// Test 4: a > 24 000-char premise must not panic. mDeBERTa-v3 is
|
|
/// trained at 512 tokens; the `OnlyFirst` truncation strategy keeps
|
|
/// the premise side from blowing the positional embedding cap.
|
|
#[test]
|
|
#[ignore]
|
|
fn long_premise_truncates_without_panic() {
|
|
let cfg = Config::defaults();
|
|
let v = OnnxNliVerifier::new(&cfg).expect("verifier construction");
|
|
let premise = "foo bar baz ".repeat(2000); // ~24 000 chars
|
|
let hypothesis = "foo";
|
|
let s = v
|
|
.score(&premise, hypothesis)
|
|
.expect("score should succeed on long premise");
|
|
eprintln!(
|
|
"[test4 long_premise_truncates_without_panic] premise_len={} \
|
|
scores: entailment={:.4}, neutral={:.4}, contradiction={:.4}",
|
|
premise.len(),
|
|
s.entailment,
|
|
s.neutral,
|
|
s.contradiction
|
|
);
|
|
// No NaN / infinity in any channel.
|
|
for (name, x) in [
|
|
("entailment", s.entailment),
|
|
("neutral", s.neutral),
|
|
("contradiction", s.contradiction),
|
|
] {
|
|
assert!(
|
|
x.is_finite(),
|
|
"channel {name} non-finite: {x} (full scores: {s:?})"
|
|
);
|
|
}
|
|
// Softmax invariant — the three channels sum to ~1.
|
|
let sum = s.entailment + s.neutral + s.contradiction;
|
|
assert!(
|
|
(sum - 1.0).abs() < 1e-3,
|
|
"softmax channels must sum to ~1, got {sum:.6}"
|
|
);
|
|
}
|
|
|
|
/// Test 5: an empty hypothesis triggers the defense-in-depth bail
|
|
/// path BEFORE the tokenizer runs. Hits no network — fast, even on
|
|
/// a fresh machine.
|
|
#[test]
|
|
#[ignore]
|
|
fn empty_hypothesis_returns_err() {
|
|
let cfg = Config::defaults();
|
|
let v = OnnxNliVerifier::new(&cfg).expect("verifier construction");
|
|
let err = v
|
|
.score("anything", "")
|
|
.expect_err("empty hypothesis must error");
|
|
let msg = err.to_string();
|
|
assert!(
|
|
msg.contains("empty hypothesis"),
|
|
"expected 'empty hypothesis' in error, got: {msg}"
|
|
);
|
|
}
|