altair823
7c85de065a
cut PR v0.18.0 전 마지막 정리. 사용자 요청: "전체 코드베이스를 깔끔하고 알아보기 쉽게".
## Workspace lints
- `Cargo.toml` 의 `[workspace.lints.clippy]` 에 `pedantic = "warn"` (priority -1) + 의도적 allow-list 추가:
- cast_possible_truncation / cast_possible_wrap / cast_sign_loss / cast_precision_loss — ONNX i64 / hash modular reduction 등 의도적 truncation.
- doc_markdown / missing_errors_doc / missing_panics_doc — cosmetic doc style.
- too_many_lines / module_name_repetitions / must_use_candidate / needless_pass_by_value / manual_let_else / items_after_statements / similar_names — informational only.
- format_collect / match_wildcard_for_single_variants / trivially_copy_pass_by_ref / unnecessary_wraps — intentional patterns (exhaustive match, future Result variants 등).
- default_trait_access — `Foo::default()` 가 idiomatic.
- float_cmp — NLI / RRF score 의 explicit threshold 비교 의도.
- struct_excessive_bools / case_sensitive_file_extension_comparisons / naive_bytecount / ignore_without_reason — domain-specific 의도.
- format_push_string / return_self_not_must_use / match_same_arms — builder / wire-label / hot-path 패턴 보존.
- needless_continue / used_underscore_binding / nonminimal_bool / unreadable_literal / many_single_char_names / doc_link_with_quotes / assigning_clones / collapsible_str_replace / trivial_regex / elidable_lifetime_names / range_plus_one / explicit_iter_loop / implicit_hasher / ref_option — remaining low-value style.
- 각 24 crate `Cargo.toml` 에 `[lints] workspace = true` 추가.
## Auto-fix
`cargo clippy --workspace --all-targets --fix` 적용 — 128 files changed, 552 insertions / 472 deletions. 주로:
- uninlined_format_args (~18): `format!("{}", x)` → `format!("{x}")`.
- redundant_closure_for_method_calls (~33): `.map(|x| x.foo())` → `.map(T::foo)`.
- 그 외 mechanical refactor.
## 검증
- `cargo clippy --workspace --all-targets -j 1 -- -D warnings` clean (pedantic + 모든 lint group).
- `cargo test --workspace --no-fail-fast -j 1` — **1293 tests pass + 1 pre-existing flaky fail** (`kebab-mcp::tools_call_ask_multi_hop::ask_tool_routes_multi_hop_true_to_decompose_first`, HOTFIX candidate, cleanup 무관). 회귀 0.
Wire 영향: 없음.
Behavior 영향: 없음 (mechanical refactor only).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
59 lines
2.5 KiB
TOML
59 lines
2.5 KiB
TOML
[package]
|
|
name = "kebab-store-vector"
|
|
version = { workspace = true }
|
|
edition = { workspace = true }
|
|
rust-version = { workspace = true }
|
|
license = { workspace = true }
|
|
repository = { workspace = true }
|
|
description = "LanceDB-backed VectorStore for kb (§5.6 embedding_records, §6.3 lancedb tables, §7.2 VectorStore)"
|
|
|
|
[dependencies]
|
|
kebab-core = { path = "../kebab-core" }
|
|
kebab-config = { path = "../kebab-config" }
|
|
# kb-store-sqlite is allowed for the embedding_records writers only
|
|
# (P3-3 spec: "Allowed dep `kb-store-sqlite` for writing/reading rows in
|
|
# embedding_records"). The Two-phase upsert flow uses
|
|
# `put_embedding_records_pending` + `mark_embedding_records_committed`.
|
|
kebab-store-sqlite = { path = "../kebab-store-sqlite" }
|
|
|
|
# LanceDB embedded vector store. `default-features=false` opts out of
|
|
# the cloud object-store integrations (aws / gcs / azure / dynamodb /
|
|
# oss); kb is always-local for v1, so dragging in those SDKs would just
|
|
# inflate the build.
|
|
lancedb = { workspace = true }
|
|
arrow = { workspace = true }
|
|
arrow-array = { workspace = true }
|
|
arrow-schema = { workspace = true }
|
|
# Embedded async runtime. The VectorStore trait is sync (§7.2) but
|
|
# LanceDB's Rust API is async-only; we own a current-thread
|
|
# tokio::Runtime and `block_on` per trait method. current-thread saves
|
|
# the two worker threads a multi-thread runtime would spawn — kb-app
|
|
# already serializes vector ops behind its own job scheduler so the
|
|
# extra parallelism wouldn't be exploited.
|
|
tokio = { workspace = true }
|
|
# `try_collect` for streaming Lance query results into a Vec<RecordBatch>.
|
|
futures = { workspace = true }
|
|
|
|
serde = { workspace = true }
|
|
serde_json = { workspace = true }
|
|
tracing = { workspace = true }
|
|
thiserror = { workspace = true }
|
|
anyhow = { workspace = true }
|
|
blake3 = { workspace = true }
|
|
time = { workspace = true }
|
|
|
|
[dev-dependencies]
|
|
tempfile = { workspace = true }
|
|
serde_json = { workspace = true }
|
|
# Integration tests seed `documents` / `chunks` fixtures by raw SQL
|
|
# (no kb-parse-md / kb-normalize / kb-chunk dep) so they can construct
|
|
# adversarial filter / dim-mismatch states. rusqlite is a `[dev-]`
|
|
# dep only — the runtime crate uses kb-store-sqlite's typed surface
|
|
# (`filter_chunks`, `put_embedding_records_pending`, …) and does not
|
|
# touch rusqlite directly (P3-3 spec: kb-store-vector must not list
|
|
# rusqlite/globset as direct deps).
|
|
rusqlite = { workspace = true }
|
|
|
|
[lints]
|
|
workspace = true
|