altair823-org/kebab
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 40 Wiki Activity

review(p9-fb-23): 회차 1 nit 반영 — named columns + safe byte_len + trait check + count

Browse Source 
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
altair823
2026-05-04 18:33:28 +00:00
parent b4aba5de3c
commit 8d0744c22b
2 changed files with 21 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
crates/kebab-store-sqlite/src/documents.rs
View File

@@ -507,24 +507,21 @@ fn rows_optional<T>(err: rusqlite::Error) -> rusqlite::Result<Option<T>> {
}
/// Reconstruct a [`kebab_core::RawAsset`] from one `assets` row.
///
/// Column order must match the SELECT in
/// [`DocumentStore::get_asset_by_workspace_path`]:
/// `asset_id(0), source_uri(1), workspace_path(2), media_type(3),
/// byte_len(4), checksum(5), storage_kind(6), storage_path(7),
/// discovered_at(8)`.
/// Row mapper for `RawAsset`. Column names are self-documenting; the
/// SELECT in [`DocumentStore::get_asset_by_workspace_path`] must include
/// all nine columns by their schema names.
fn asset_from_row(row: &rusqlite::Row<'_>) -> rusqlite::Result<kebab_core::RawAsset> {
use std::path::PathBuf;
let asset_id: String = row.get(0)?;
let source_uri_raw: String = row.get(1)?;
let workspace_path_raw: String = row.get(2)?;
let media_type_json: String = row.get(3)?;
let byte_len: i64 = row.get(4)?;
let checksum_raw: String = row.get(5)?;
let storage_kind: String = row.get(6)?;
let storage_path_raw: String = row.get(7)?;
let discovered_at_raw: String = row.get(8)?;
let asset_id: String = row.get("asset_id")?;
let source_uri_raw: String = row.get("source_uri")?;
let workspace_path_raw: String = row.get("workspace_path")?;
let media_type_json: String = row.get("media_type")?;
let byte_len: i64 = row.get("byte_len")?;
let checksum_raw: String = row.get("checksum")?;
let storage_kind: String = row.get("storage_kind")?;
let storage_path_raw: String = row.get("storage_path")?;
let discovered_at_raw: String = row.get("discovered_at")?;
// Parse source_uri: stored as "file://<path>" or "kb://<uri>".
let source_uri = if let Some(path_str) = source_uri_raw.strip_prefix("file://") {
@@ -558,7 +555,14 @@ fn asset_from_row(row: &rusqlite::Row<'_>) -> rusqlite::Result<kebab_core::RawAs
source_uri,
workspace_path,
media_type,
byte_len: byte_len as u64,
byte_len: u64::try_from(byte_len)
.map_err(|e| rusqlite::Error::FromSqlConversionFailure(
// index parameter for named-column path is unused but the
// type still requires a number; pass 0 with a clear msg.
0,
rusqlite::types::Type::Integer,
Box::new(e),
))?,
checksum,
discovered_at,
stored,

2
tasks/HOTFIXES.md
View File

@@ -31,7 +31,7 @@ git history.
**Spec contract impact**: design §9 versioning cascade 의 명시적 동작 추가 — parser/chunker/embedder version bump 시 다음 ingest 가 자동으로 모든 doc 을 `updated` 로 처리. 기존엔 silently 새 version 으로 overwrite (idempotent UPSERT) 였으나 본 변경으로 explicit refresh + 비용 회피 모두 보장. design §3.x IngestReport / §2.4a IngestEvent 에 `Unchanged` variant 추가 (additive, wire v1 호환).
**Tests added**: 약 10 신규. 기존 ~720 워크스페이스 테스트 무수정 통과.
**Tests added**: 8 신규 (`crates/kebab-app/tests/incremental_ingest.rs` 2 + `crates/kebab-app/tests/ingest_lexical.rs` 2 + `crates/kebab-store-sqlite/tests/incremental_ingest.rs` 4) + 3 기존 갱신 (`image_pipeline.rs` / `pdf_pipeline.rs` / `ingest_lexical.rs::ingest_idempotent_on_second_run` 의 assertion 이 Updated → Unchanged 로 변경). 기존 ~720 워크스페이스 테스트 무수정 통과.
**Known limitation (deferred)**: