th-kim0823
787007172a
fix(fb-39b): address PR #137 round 2 review
...
- target_version 0.7.0 → 0.6.0 (current Cargo.toml = 0.5.0;
embedding_version cascade bumps to 0.6, not 0.7)
- 요약 bullet "0.6 → 0.7" → "0.5 → 0.6" 정정
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com >
2026-05-10 23:47:47 +09:00
th-kim0823
b954e9ce66
fix(fb-39b): address PR #137 round 1 review
...
- CI-only embed_model.rs tests updated 384 → 1024 + e5-small → e5-large
references (incl. file header download size, snapshot dim assert,
L2 norm comment)
- kebab-embed-local module docs + Cargo.toml description list both
models (small + large)
- Stale tracing message expanded with both model sizes
- Task spec Post-merge deviation section: record dropped
embedding_dim_mismatch ErrorV1 + reason (LanceDB (model, dim)
namespacing makes hard-error redundant)
- Task spec + HOTFIXES version bump 0.6→0.7 corrected to 0.5→0.6
(current Cargo.toml = 0.5.0; fb-42 0.6 cut deferred per user
direction)
- HOTFIXES "embedding_version bump 아님" line corrected — cascade rule
DOES trigger release bump, plus deviation note for the dropped error
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com >
2026-05-10 23:45:55 +09:00
th-kim0823
c62a8ff503
docs(fb-39b): design + HOTFIXES + new task spec + INDEX + README + SMOKE
...
Tasks 4 + 5: comprehensive doc update for embedding upgrade (multilingual-e5-large).
- design §5 + §9: update embedding_model / dimensions references (384 -> 1024)
- HOTFIXES: add fb-39b entry with user re-ingest procedure + backwards-compat notes
- tasks/p9-fb-39b-embedding-upgrade.md: new task spec (completed status)
- INDEX.md: add fb-39b row under RAG quality phase
- fb-39 task banner: append fb-39b link as lever implementation
- README: update config defaults + fastembed model size + embedding field docs
- SMOKE.md: append embedding upgrade verification section with e5-small -> e5-large sequence
Wire schema: no change (additive at config level, new table created by existing code).
Binary version: 0.6.0 -> 0.7.0 (cascade rule: embedding_model change = minor bump).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com >
2026-05-10 23:28:48 +09:00
th-kim0823
69c94b6692
feat(embed,config): add multilingual-e5-large + flip default config (fb-39b)
...
Task 1: Add multilingual-e5-large arm to kebab-embed-local::resolve_model with tests for 1024-dim variants and error cases.
Task 2: Flip kebab-config defaults from e5-small (384-dim) to e5-large (1024-dim) across defaults(), test assertions, and TOML template.
All tests pass; clippy clean.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com >
2026-05-10 23:05:36 +09:00
th-kim0823
d5321701ea
plan(fb-39b): embedding upgrade implementation plan
...
5 tasks: kebab-embed-local resolve_model arm + check_dim test,
kebab-config defaults + TOML template flip, cross-crate fixture
sweep (likely no-op since most tests use provider=none), docs
(design + HOTFIXES + new task spec + INDEX), README + SMOKE
walkthrough.
Post-merge: 0.6 → 0.7 binary bump per CLAUDE.md cascade rule.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com >
2026-05-10 23:02:37 +09:00
th-kim0823
2c3461c465
spec(fb-39b): embedding model upgrade design
...
- multilingual-e5-small (384 dim) → multilingual-e5-large (1024 dim)
- Cascade: embedding_version bump → fb-23 incremental ingest
re-embeds all chunks
- Migration policy: dim mismatch detection at LanceVectorStore::open
→ error.v1 (code = embedding_dim_mismatch) + hint
"kebab reset --vector-only && kebab ingest"
- Config defaults flip (model + dimensions). User TOML pinning small
preserves backwards-compat
- bge-m3 deferred (fastembed enum 미포함, UserDefinedEmbeddingModel
ONNX path 별도)
- Release trigger: 0.6 → 0.7 minor bump per CLAUDE.md cascade rule
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com >
2026-05-10 22:59:03 +09:00
